feat: Add custom notifications for each site #255
+2,583
−246,305
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in https://github.com/orgs/upptime/discussions/930 , it would be nice to set diffrent notification for each site.
I know that the isse proposed to add that feature to send emails but for the first step this PR only adds webhooks.
Before I invest more time in that, it would be nice to know if my intensions are right.
@AnandChowdhary Do you have any ideas or comments on that ?
Currently I would change the current behaviour to only send general notifications for sites that have no custom notification type set and the custom ones for that they are configurrf
Furthermore I can imagine to refactor the
update
andsendNotification
to make it more readable and easier to add more feature in the future.Feel free to comment ✌️
Best @coolusaHD