Skip to content

[bladectl][grpc] define a proper API #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
xvzf opened this issue Jul 26, 2023 · 1 comment
Open

[bladectl][grpc] define a proper API #5

xvzf opened this issue Jul 26, 2023 · 1 comment

Comments

@xvzf
Copy link
Collaborator

xvzf commented Jul 26, 2023

The current API is hacky&just a placeholder
@DaveSaah
Copy link

Hello,

If its possible, could you specify the requirements? I would like to work on this.

cedi added a commit to cedi/compute-blade-agent that referenced this issue May 7, 2025
@cedi
# This is a combination of 15 commits.
76e506b 
# This is the 1st commit message:

refactor(fancontroller): improve fan controller validation logic and error handling for temperature steps

# This is the commit message #2:

refactor(agent): restructure gRPC server implementation by moving it to a new api package for better organization and maintainability

# This is the commit message #3:

feat(agent): implement gRPC server for managing compute blade agents and add graceful shutdown support
refactor(agent): restructure agent code by moving API logic to a dedicated file and improving error handling
fix(agent): update logging messages for clarity and consistency across the agent's operations
chore(agent): remove unused API code and consolidate event handling logic for better maintainability
style(agent): improve code formatting and organization for better readability and adherence to conventions

# This is the commit message uptime-industries#4:

feat(agent): add support for TLS configuration in gRPC server

# This is the commit message uptime-industries#5:

feat(api): add gRPC server authentication

# This is the commit message uptime-industries#6:

fix

# This is the commit message uptime-industries#7:

feat(config): add listen mode configuration to support tcp or unix sockets
feat(agent): implement listen mode in gRPC service to allow flexible socket types
feat(bladectl): enhance configuration loading and add support for TLS credentials
fix(bladectl): improve error handling for gRPC connection and event emission
style(logging): change log level from Warn to Info for better clarity in logs

# This is the commit message uptime-industries#8:

add logging middleware + fixes

# This is the commit message uptime-industries#9:

fix remote-connection to gRPC API Server

debugging the SAN issues took the soul out of me... And then the stupid
mistake in cmd_root where I didn't construct the TLS credentials
correctly... Oh dear...

# This is the commit message uptime-industries#10:

cleanup

# This is the commit message uptime-industries#11:

cleanup

# This is the commit message uptime-industries#12:

cleanup commands

# This is the commit message uptime-industries#13:

cleanup

# This is the commit message uptime-industries#14:

make README.md nicer

# This is the commit message uptime-industries#15:

smaller PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xvzf @DaveSaah