Memory update #3
Conversation
Dockerfile
Outdated
| "-XX:MaxMetaspaceFreeRatio=80", \ | ||
| "-XX:+ExplicitGCInvokesConcurrent", \ | ||
| "-XX:InitialRAMPercentage=5.0", \ | ||
| # "-XX:MaxRAMPercentage=50.0", \ |
There was a problem hiding this comment.
should the # "-XX:MaxRAMPercentage=50.0", \ still be here?
There was a problem hiding this comment.
This parameter has been removed. in favor of using the allocated memory limits instead of percentage based limits.
docker-compose.yml
Outdated
| @@ -25,6 +28,12 @@ services: | |||
| ENABLE_ODE_RAW_ENCODED_TIM_DEDUPLICATION: ${ENABLE_ODE_RAW_ENCODED_TIM_DEDUPLICATION} | |||
| ENABLE_PROCESSED_SPAT_DEDUPLICATION: ${ENABLE_PROCESSED_SPAT_DEDUPLICATION} | |||
| ENABLE_ODE_BSM_DEDUPLICATION: ${ENABLE_ODE_BSM_DEDUPLICATION} | |||
| DEDUPLICATOR_ROCKSDB_TOTAL_OFF_HEAP_MEMORY: ${DEDUPLICATOR_ROCKSDB_TOTAL_OFF_HEAP_MEMORY:?error} | |||
There was a problem hiding this comment.
Do we need to error out if it isn't set? Seems like defaults are provided in the source code.
| "-Dlogback.configurationFile=/home/logback.xml", \ | ||
| "-Xmx1024M", \ |
There was a problem hiding this comment.
Will this make it, so this image's JVM won't be able to use more than 1Gb of memory?
There was a problem hiding this comment.
Yes. This sets the containers memory limit to 1 GB. Currently 1 deduplicator is able to handle about 27 intersections for CDOT. Any more intersections and we should probably move to scaling horizontally instead of vertically.
No description provided.