Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated git submodule commit references to latest master branch commits #541

Merged

Conversation

dmccoystephenson
Copy link
Collaborator

@dmccoystephenson dmccoystephenson commented Mar 6, 2024

PR Details

Description

The git submodule commit references are currently pointing to commits that are 4 months old. These should be pointing to the latest commits on the master branch for each respective git submodule.

It should be noted that while this is technically a new version, the versions in the pom.xml files have not been updated as there were no changes to the functionality of the ODE.

Related Issue

No related issue.

Motivation and Context

It is important that these git submodule commit references are pointing to compatible versions of the git submodules. At this time, a user that clones the project and runs git submodule update will have git submodule versions that are incompatible with v2 of the ODE.

How Has This Been Tested?

Running git submodule update --init --recursive on a fresh clone of the 'jpo-ode' project results in the proper versions of the git submodules being targeted:

image

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)
  • Git submodule commit reference updates

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
    ODE Contributing Guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Collaborator

@drewjj drewjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the new commit references check out.

Copy link
Collaborator

@payneBrandon payneBrandon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ltgm, referenced module commits are all the latest tagged versions of the respective submodules.

@dan-du-car
Copy link
Contributor

Thank you for this update!

@SaikrishnaBairamoni SaikrishnaBairamoni merged commit 6f6f094 into usdot-jpo-ode:master Mar 6, 2024
2 checks passed
@dmccoystephenson dmccoystephenson deleted the hotfix/hotfix_2.0.1 branch March 6, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants