-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update TIM Schema Test #558
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t include the "asn1" field
…-ingest-log-alerts
…nd developer experience (#105) * README additions and trivial markdown format corrections * replace outdated ifconfig command with ip command in sample.env * Add .PHONY entries to Makefile since tasks don't reference local files * add makefile-tools to dev container extensions * add ignore = all to submodules to simplify local development and commit process * correct links in README and correct linter warnings where sensible and easy * clarify .env file setup steps * Revert "add makefile-tools to dev container extensions" This reverts commit 29f3e64. * Revert "add ignore = all to submodules to simplify local development and commit process" This reverts commit 788f38c. * add ignore = all to submodules to prevent commits w/ changes to submodules * add python3 support to dev container * Revert "correct links in README and correct linter warnings where sensible and easy" This reverts commit 081e9db. * correct link to Contributing Guide in pr template * adjust README internal links to markdown syntax for local functionality * Revert "add ignore = all to submodules to prevent commits w/ changes to submodules" This reverts commit 15a7e44.
…-ingest-log-alerts
…ity-guide-for-v3 Submodule Compatibility Guide Entry for ODE 3.0.0
…-for-jpo-utils Update Release Documentation to Include `jpo-utils` Submodule
…ents. Also supports the circle TIMs better.
…ane default in catch block
…ng apart the monstrosity (#110) * Migrate kafka configuration values to ODEKafkaProperties This is the first part of the work needed to separate the OdeProperties into multpile more manageable chunks. It introduces the usage of application.yaml and @Autowired in tests to more fully utilize the Spring framework. * remove @component annotation and accept linter errors Adding the @component annotation to the *Receivers caused double instantiations and port binding issues * migrate from application.properties to application.yaml and introducde host-ip config val * add make restart target for easier, faster restarts that don't require a full image rebuild * add missing getHostId test for odekafkaproperties * move odekafkaproperties to kafka package * correctly declare restart target as PHONY in Makefile * move OdeKafkaPropertiesTest to correct test package * add tests to OdePropertiesTest for hostIP and remove unused imports and variables * moved hostID from OdeKafkaProperties to AppContext to keep scope of new class small and directed * correct application.yaml's disabled-topics block * correct formatting in Asn1*JSONTest.java files and fix Sonarlint errors All swaps of argument positions in the mentioned tests are to align the function calls to the defition: assert*(expected, actual). Before this swap, the call was made in the tests like assert*(actual, expected) which has the same outcome when tests *pass* but is confusing when tests do not pass because the failure output will have the actual and expected values swapped in the message. * add sprint.http.multipart config values to application.yaml * Add TODO for @mcook42 to update README.md with corrected instructions once OdeProperties refactor is completed
…-ingest-log-alerts
Add configurable alert to print log statement warning of missing TIMs deposits
…roducer.java Co-authored-by: Matt Cook <mattheworion.cook@gmail.com>
…ue to ODE shinanigans
Update TIM schema
Add Generated TMC TIM Topic
Adding Compression to Ode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Description
This includes a fix to the TIM schema test that was not updated when the TIM schema was updated. It properly updates the schema validator to validate the schema with the proper latest schema version "V202012".
Related Issue
N/A
Motivation and Context
The unit test was failing.
How Has This Been Tested?
This has been tested locally.
Types of changes
Checklist:
ODE Contributing Guide