Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Updates Go to 1.23 #53

Merged
merged 5 commits into from
Feb 5, 2025
Merged

Chore: Updates Go to 1.23 #53

merged 5 commits into from
Feb 5, 2025

Conversation

CGoodwin90
Copy link
Contributor

Updates Go to 1.23

@CGoodwin90 CGoodwin90 marked this pull request as ready for review January 2, 2025 01:06
shreddedbacon
shreddedbacon reviewed Jan 23, 2025
View reviewed changes
@CGoodwin90 @shreddedbacon
Update Dockerfile
471b18a 
Co-authored-by: Ben Jackson <shreddedbacon@users.noreply.github.com>
@shreddedbacon
Copy link
Member

shreddedbacon commented Jan 23, 2025 •
edited
Loading

As with uselagoon/insights-handler#97 this repo doesn't have tests coverage in github actions.

I tried to run go test ./... locally with this branch, but it fails. Does it fail for you locally too?

bomoko
bomoko approved these changes Feb 5, 2025
View reviewed changes
Copy link
Collaborator

@bomoko bomoko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - I ran and tested this in test6 as well. I'm going to open a separate issue to sort out the local test run (which is also an issue in main)

@bomoko bomoko merged commit e48957f into main Feb 5, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shreddedbacon shreddedbacon shreddedbacon left review comments

@bomoko bomoko bomoko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
go 1.23 rollout
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CGoodwin90 @shreddedbacon @bomoko