Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: add branches and pullrequests during org project creation #276

Merged
merged 11 commits into from
Jul 4, 2024

Conversation

DaveDarsa
Copy link
Contributor

will close #267
Screenshot 2024-07-01 at 01 26 10

@shreddedbacon if branches and pullrequests aren't provided they're set to true, but the api doesn't allow non-string values, so currently this PR sends values as stringified values. seems wrong

@shreddedbacon
Copy link
Member

branches and pullrequests are string values, so they should be free text boxes that are optionally filled in by the user

the API will default these to a string representation of "true" if they are not provided.

@shreddedbacon
Copy link
Member

shreddedbacon commented Jun 30, 2024

Can we put a tooltip (?) next to branches and pullrequests that expands what the API has in the descriptions for those fields? It might be a bit helpful

    """
    Which branches should be deployed, can be one of:
    - \`true\` - all branches are deployed
    - \`false\` - no branches are deployed
    - REGEX - regex of all branches that should be deployed, example: \`^(main|staging)$\`
    """
    branches: String
    """
    Which Pull Requests should be deployed, can be one of:
    - \`true\` - all pull requests are deployed
    - \`false\` - no pull requests are deployed
    - REGEX - regex of all Pull Request titles that should be deployed, example: \`[BUILD]\`
    """
    pullrequests: String

Maybe tidied up a bit to fit better in a tooltip, something like these:

Branches

Which Pull Requests should be deployed, can be one of:
- true - all branches are deployed
- false - no branches are deployed
- regex of all branches that can be deployed (including production), example: '^(main|staging)$'

Pullrequests

Which branches should be deployed, can be one of:
- true - all pull requests are deployed
- false - no pull requests are deployed
- regex of all Pull Request titles that can be deployed, example: '[BUILD]'

@shreddedbacon
Copy link
Member

Hmm, bit too spacey?
image

@shreddedbacon shreddedbacon added this to the 2.20.0 milestone Jul 4, 2024
@shreddedbacon
Copy link
Member

This looks fine. I wonder if the first - of each line could be a dot though maybe?
image

Like this

  • true - all pull requests are deployed
  • false - no pull requests are deployed
  • regex of all Pull Request titles that can be deployed, example: '[BUILD]'

Copy link
Member

@shreddedbacon shreddedbacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
Looks good!

@DaveDarsa DaveDarsa requested a review from shreddedbacon July 4, 2024 07:24
Copy link
Member

@tobybellwood tobybellwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@DaveDarsa DaveDarsa merged commit ef6950b into main Jul 4, 2024
6 of 8 checks passed
@DaveDarsa DaveDarsa deleted the additional-project-fields branch July 4, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Organization project creation additional fields
3 participants