Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add org env vars to the organizations section #313

Merged
merged 3 commits into from
Mar 11, 2025

Conversation

rocketeerbkw
Copy link
Member

UI support for uselagoon/lagoon#3856

@rocketeerbkw
Copy link
Member Author

I don't know why the cypress tests are failing where they are, it looks like a keycloak url changed? I don't know what I could've done in this PR to cause that.

1) Navigation tests
       Checks navigation to settings, organizations and projects pages:

      Timed out retrying after 8000ms
      + expected - actual

      -'\'http://localhost:8088/auth/realms/lagoon/account\''
      +'\'http://localhost:8088/auth/realms/lagoon/account/\''
      
      at Suite.eval (webpack:///./e2e/general/navigation.cy.ts:33:0)
      at Context.eval (webpack:///./e2e/general/navigation.cy.ts:29:0)

@DaveDarsa
Copy link
Contributor

I think it's because of the keycloak upgrade a while back

@shreddedbacon
Copy link
Member

shreddedbacon commented Mar 5, 2025

Yeah, was fixed here too in #312

const redirect = `${Cypress.env('keycloak')}/realms/lagoon/account`;
.

Copy link
Member

@tobybellwood tobybellwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works as expected!

@tobybellwood
Copy link
Member

Noting here that there's no functionality yet for showing at the project level any organizational variables that may be set.

@tobybellwood tobybellwood merged commit ce85294 into main Mar 11, 2025
4 checks passed
@tobybellwood tobybellwood deleted the orgs-modify-env-vars branch March 11, 2025 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants