Merge pull request #3702 from uselagoon/actions-handler-environment-fix

fix: get environment by namespacename before getting deployment

services/actions-handler/handler/controller_builds.go

@@ -39,7 +39,23 @@ func (m *Messenger) handleBuild(ctx context.Context, messageQueue *mq.MessageQue
 
 	// set up a lagoon client for use in the following process
 	l := lclient.New(m.LagoonAPI.Endpoint, "actions-handler", &token, false)
-	deployment, err := lagoon.GetDeploymentByName(ctx, message.Meta.Project, message.Meta.Environment, message.Meta.BuildName, false, l)
+	environment, err := lagoon.GetEnvironmentByNamespace(ctx, message.Namespace, l)
+	if err != nil || environment == nil {
+		if err != nil {
+			m.toLagoonLogs(messageQueue, map[string]interface{}{
+				"severity": "error",
+				"event":    fmt.Sprintf("actions-handler:%s:failed", "updateDeployment"),
+				"meta":     environment,
+				"message":  err.Error(),
+			})
+			if m.EnableDebug {
+				log.Println(fmt.Sprintf("%sERROR:unable to get environment by namespace - %v", prefix, err))
+			}
+			return err
+		}
+	}
+	environmentID := environment.ID
+	deployment, err := lagoon.GetDeploymentByName(ctx, message.Meta.Project, environment.Name, message.Meta.BuildName, false, l)
 	if err != nil {
 		m.toLagoonLogs(messageQueue, map[string]interface{}{
 			"severity": "error",
@@ -60,58 +76,6 @@ func (m *Messenger) handleBuild(ctx context.Context, messageQueue *mq.MessageQue
 		}
 		return nil
 	}
-	var environmentID uint
-	environment := &schema.Environment{}
-	// determine the environment id from the message
-	if message.Meta.ProjectID == nil && message.Meta.EnvironmentID == nil {
-		project, err := lagoon.GetMinimalProjectByName(ctx, message.Meta.Project, l)
-		if err != nil {
-			// send the log to the lagoon-logs exchange to be processed
-			m.toLagoonLogs(messageQueue, map[string]interface{}{
-				"severity": "error",
-				"event":    fmt.Sprintf("actions-handler:%s:failed", "updateDeployment"),
-				"meta":     project,
-				"message":  err.Error(),
-			})
-			if m.EnableDebug {
-				log.Println(fmt.Sprintf("%sERROR: unable to get project - %v", prefix, err))
-			}
-			return err
-		}
-		environment, err = lagoon.GetEnvironmentByName(ctx, message.Meta.Environment, project.ID, l)
-		if err != nil {
-			// send the log to the lagoon-logs exchange to be processed
-			m.toLagoonLogs(messageQueue, map[string]interface{}{
-				"severity": "error",
-				"event":    fmt.Sprintf("actions-handler:%s:failed", "updateDeployment"),
-				"meta":     environment,
-				"message":  err.Error(),
-			})
-			if m.EnableDebug {
-				log.Println(fmt.Sprintf("%sERROR: unable to get environment - %v", prefix, err))
-			}
-			return err
-		}
-		environmentID = environment.ID
-	} else {
-		// pull the id from the message
-		environmentID = *message.Meta.EnvironmentID
-		environment, err = lagoon.GetEnvironmentByID(ctx, environmentID, l)
-		if err != nil {
-			// send the log to the lagoon-logs exchange to be processed
-			m.toLagoonLogs(messageQueue, map[string]interface{}{
-				"severity": "error",
-				"event":    fmt.Sprintf("actions-handler:%s:failed", "updateDeployment"),
-				"meta":     environment,
-				"message":  err.Error(),
-			})
-			if m.EnableDebug {
-				log.Println(fmt.Sprintf("%sERROR: unable to get environment - %v", prefix, err))
-			}
-			return err
-		}
-	}
-
 	// prepare the deployment patch for later step
 	statusType := schema.StatusTypes(strings.ToUpper(buildStatus))
 	updateDeploymentPatch := schema.UpdateDeploymentPatchInput{

tests/tasks/api/get-latest-deployment-source.yaml

@@ -28,7 +28,7 @@
           query: '{{ lookup("template", "./get-latest-deployment-source.gql") }}'
       register: apiresponse
 
-    - name: "{{ testname }} - POST api trigger bulk deployment for environments to {{ graphql_url }}"
+    - name: "{{ testname }} - POST api check response {{ graphql_url }}"
       debug:
         msg: "api response: {{ apiresponse.json }}"
 
@@ -49,6 +49,6 @@
       retries: 60
       delay: 10
 
-    - name: "{{ testname }} - POST api trigger bulk deployment for environments to {{ graphql_url }}"
+    - name: "{{ testname }} - POST api check response {{ graphql_url }}"
       debug:
         msg: "api response: {{ apiresponse.json }}"

tests/tasks/api/get-latest-deployment-status.gql

@@ -0,0 +1,19 @@
+query environmentByKubernetesNamespaceName {
+  environmentByKubernetesNamespaceName(
+    kubernetesNamespaceName: "{{ namespace }}"
+  ){
+    deployments(limit: 1){
+      id
+      name
+      status
+      bulkId
+      bulkName
+      priority
+      started
+      created
+      completed
+      sourceUser
+      sourceType
+    }
+  }
+}

tests/tasks/api/get-latest-deployment-status.yaml

@@ -0,0 +1,53 @@
+- name: "{{ testname }} - Verify that status are correct"
+  block:
+    - ansible.builtin.include_tasks: admin-token.yaml
+    - name: "{{ testname }} - POST api check latest deployment {{ graphql_url }}"
+      uri:
+        url: "{{ graphql_url }}"
+        method: POST
+        headers:
+          Authorization: "Bearer {{ admin_token }}"
+        body_format: json
+        body:
+          query: '{{ lookup("template", "./get-latest-deployment-status.gql") }}'
+      register: apiresponse
+      until:
+        - apiresponse.json.data.environmentByKubernetesNamespaceName.deployments[0].status is defined
+      retries: 30
+      delay: 10
+
+    - ansible.builtin.include_tasks: admin-token.yaml
+    - name: "{{ testname }} - POST api check latest deployment {{ graphql_url }}"
+      uri:
+        url: "{{ graphql_url }}"
+        method: POST
+        headers:
+          Authorization: "Bearer {{ admin_token }}"
+        body_format: json
+        body:
+          query: '{{ lookup("template", "./get-latest-deployment-status.gql") }}'
+      register: apiresponse
+
+    - name: "{{ testname }} - POST api check response {{ graphql_url }}"
+      debug:
+        msg: "api response: {{ apiresponse.json }}"
+
+    - ansible.builtin.include_tasks: admin-token.yaml
+    - name: "{{ testname }} - POST api check latest deployment status are correct {{ graphql_url }}"
+      uri:
+        url: "{{ graphql_url }}"
+        method: POST
+        headers:
+          Authorization: "Bearer {{ admin_token }}"
+        body_format: json
+        body:
+          query: '{{ lookup("template", "./get-latest-deployment-status.gql") }}'
+      register: apiresponse
+      until:
+        - apiresponse.json.data.environmentByKubernetesNamespaceName.deployments[0].status == buildStatus
+      retries: 60
+      delay: 10
+
+    - name: "{{ testname }} - POST api check response {{ graphql_url }}"
+      debug:
+        msg: "api response: {{ apiresponse.json }}"

tests/tests/github/branch-picky.yaml

@@ -24,6 +24,15 @@
     project: "{{ project }}"
     url: "{{ check_url }}"
 
+- name: "{{ testname }} - api check deployment status"
+  hosts: localhost
+  serial: 1
+  vars:
+    namespace: "{{ project | regex_replace('_', '-') }}-{{ branch | regex_replace('/', '-') }}"
+    buildStatus: "complete"
+  tasks:
+  - ansible.builtin.include_tasks: ../../tasks/api/get-latest-deployment-status.yaml
+
 - name: "{{ testname }} - webhook github delete push"
   hosts: localhost
   serial: 1

tests/tests/github/branch.yaml

@@ -88,6 +88,15 @@
     project: "{{ project }}"
     url: "{{ check_url }}"
 
+- name: "{{ testname }} - api check deployment status"
+  hosts: localhost
+  serial: 1
+  vars:
+    namespace: "{{ project | regex_replace('_', '-') }}-{{ branch | regex_replace('/', '-') }}"
+    buildStatus: "complete"
+  tasks:
+  - ansible.builtin.include_tasks: ../../tasks/api/get-latest-deployment-status.yaml
+
 - name: "{{ testname }} - webhook github delete push"
   hosts: localhost
   serial: 1

tests/tests/gitlab/branch.yaml

@@ -78,6 +78,15 @@
     project: "{{ project }}"
     url: "{{ check_url }}"
 
+- name: "{{ testname }} - api check deployment status"
+  hosts: localhost
+  serial: 1
+  vars:
+    namespace: "{{ project | regex_replace('_', '-') }}-{{ branch | regex_replace('/', '-') }}"
+    buildStatus: "complete"
+  tasks:
+  - ansible.builtin.include_tasks: ../../tasks/api/get-latest-deployment-status.yaml
+
 - name: "{{ testname }} - webhook gitlab delete push"
   hosts: localhost
   serial: 1

tests/tests/nginx/nginx.yaml

@@ -170,6 +170,15 @@
   tasks:
   - ansible.builtin.include_tasks: ../../tasks/api/get-latest-deployment-source.yaml
 
+- name: "{{ testname }} - api check deployment status"
+  hosts: localhost
+  serial: 1
+  vars:
+    namespace: "{{ project | regex_replace('_', '-') }}-{{ branch | regex_replace('/', '-') }}"
+    buildStatus: "complete"
+  tasks:
+  - ansible.builtin.include_tasks: ../../tasks/api/get-latest-deployment-status.yaml
+
 - name: "{{ testname }} - api deleteEnvironment on {{ project }}, which should remove all resources"
   hosts: localhost
   serial: 1