Skip to content

Assign top coin ranks for top 5, 10, 20 (No roles for bots) #525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 22, 2024

Conversation

Elfshot
Copy link
Contributor

@Elfshot Elfshot commented May 28, 2024

Summary of Changes

Add extra env vars for extra role ids.
Change cron job for adding top 10 coin holders to add/remove top x coin roles

Related Issues

Resolves #462 and #467
Conflicts with PR #470

Steps to Reproduce

  • Add new role ids to env
  • Add at least 20 users to coin db with some bots
  • Trigger cron job
  • ensure the top 5, 10, and 20 have their respective roles and bots have no roles

Demonstration of Changes

Top x coin holder images 1-5 have top 5

image
image

6-10 have top 10

image
image

Before no bot commit, bots steal the position from leaderboards:
image
After, bots are completely excluded from consideration (this bot would be top 5):
image

I'll omit the rest of the images.
Position 11-20 have top 20 roles
I, position 21 have no role

@Elfshot Elfshot linked an issue May 28, 2024 that may be closed by this pull request
@Elfshot
Copy link
Contributor Author

Elfshot commented Jun 3, 2024

Latest commit resolves #467

@Elfshot Elfshot changed the title Assign top coin ranks for top 5, 10, 20 Assign top coin ranks for top 5, 10, 20 (No roles for bots) Jun 3, 2024
Copy link
Contributor

@Fan-Yang-284 Fan-Yang-284 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Nice job handling the infinite loop as well. Would you mind adding a commit to update the staging vars.json before merging, and then @probro27 or I will update the prod vars.json as well after we create the new roles in the main server.

@Elfshot Elfshot requested a review from Fan-Yang-284 June 12, 2024 00:37
Copy link
Contributor

@probro27 probro27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Elfshot LGTM! I will check the vars.json in prod and then push the code there. Thanks for working on this :D

@Elfshot Elfshot merged commit 41a2dab into main Jun 22, 2024
2 checks passed
@Elfshot Elfshot deleted the 462-expand-top-10-codey-coin-holders-to-top51020 branch June 22, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bots should not be able to have the Top 10 Coin Holder role Expand top 10 codey coin holders to top5/10/20
3 participants