try to solve more spmd/ccl issues

uxlfoundation · Mar 4, 2025 · 0d1bbbd · 0d1bbbd
1 parent 11f563b
commit 0d1bbbd
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/cpp/oneapi/dal/detail/ccl/communicator.hpp b/cpp/oneapi/dal/detail/ccl/communicator.hpp
@@ -107,7 +107,7 @@ class ccl_stream_wrapper {
 /// Implementation of the low-level SPMD communicator interface via ccl
 /// TODO: Currently message sizes are limited via `int` type.
 ///       Large message sizes should be handled on the communicator side in the future.
-class ccl_device_communicator_impl : public spmd::communicator_iface {
+class ONEDAL_EXPORT ccl_device_communicator_impl : public spmd::communicator_iface {
 public:
     // Explicitly declare all virtual functions with overloads to workaround Clang warning
     // https://stackoverflow.com/questions/18515183/c-overloaded-virtual-function-warning-by-clang

diff --git a/cpp/oneapi/dal/detail/common.cpp b/cpp/oneapi/dal/detail/common.cpp
@@ -83,7 +83,7 @@ template struct ONEDAL_EXPORT integer_overflow_ops<std::size_t>;
 namespace oneapi::dal::preview::detail {
 
 #ifdef ONEDAL_DATA_PARALLEL
-void check_if_pointer_matches_queue(const sycl::queue& q, const void* ptr) {
+void ONEDAL_EXPORT check_if_pointer_matches_queue(const sycl::queue& q, const void* ptr) {
     if (ptr) {
         if (!dal::backend::is_known_usm(q, ptr)) {
             throw invalid_argument{ dal::detail::error_messages::unknown_usm_pointer_type() };

diff --git a/cpp/oneapi/dal/detail/common.hpp b/cpp/oneapi/dal/detail/common.hpp
@@ -474,7 +474,7 @@ static constexpr void deallocate(Alloc& alloc,
 }
 
 #ifdef ONEDAL_DATA_PARALLEL
-void check_if_pointer_matches_queue(const sycl::queue& q, const void* ptr);
+void ONEDAL_EXPORT check_if_pointer_matches_queue(const sycl::queue& q, const void* ptr);
 #endif
 
 } // namespace oneapi::dal::preview::detail