FIX: addressing Coverity hits on Ridge (#3071)

uxlfoundation · Feb 18, 2025 · 70b9dd1 · 70b9dd1
1 parent c181894
commit 70b9dd1
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 0 deletions.
diff --git a/cpp/daal/include/algorithms/ridge_regression/ridge_regression_predict_types.h b/cpp/daal/include/algorithms/ridge_regression/ridge_regression_predict_types.h
@@ -106,6 +106,9 @@ class DAAL_EXPORT Input : public linear_model::prediction::Input
     /** Copy constructor */
     Input(const Input & other);
 
+    /** Assign operator */
+    Input & operator=(const Input & other);
+
     /**
      * Returns an input object for making ridge regression model-based prediction
      * \param[in] id    Identifier of the input object

diff --git a/cpp/daal/include/algorithms/ridge_regression/ridge_regression_training_types.h b/cpp/daal/include/algorithms/ridge_regression/ridge_regression_training_types.h
@@ -136,8 +136,13 @@ class DAAL_EXPORT Input : public linear_model::training::Input, public InputIfac
 public:
     /** Default constructor */
     Input();
+
+    /** Copy constructor */
     Input(const Input & other);
 
+    /** Assignment operator */
+    Input & operator=(const Input & other);
+
     virtual ~Input() {}
 
     /**
@@ -283,6 +288,7 @@ class DAAL_EXPORT DistributedInput<step2Master> : public daal::algorithms::Input
 public:
     DistributedInput();
     DistributedInput(const DistributedInput & other);
+    DistributedInput operator=(const DistributedInput & other);
 
     /**
      * Gets an input object for ridge regression model-based training in the second step of the distributed processing mode

diff --git a/cpp/daal/src/algorithms/ridge_regression/ridge_regression_prediction_batch.cpp b/cpp/daal/src/algorithms/ridge_regression/ridge_regression_prediction_batch.cpp
@@ -42,6 +42,7 @@ __DAAL_REGISTER_SERIALIZATION_CLASS(Result, SERIALIZATION_RIDGE_REGRESSION_PREDI
 /** Default constructor */
 Input::Input() : linear_model::prediction::Input(lastModelInputId + 1) {}
 Input::Input(const Input & other) : linear_model::prediction::Input(other) {}
+Input & Input::operator=(const Input & other) = default;
 
 /**
  * Returns an input object for making ridge regression model-based prediction

diff --git a/cpp/daal/src/algorithms/ridge_regression/ridge_regression_training_input.cpp b/cpp/daal/src/algorithms/ridge_regression/ridge_regression_training_input.cpp
@@ -38,6 +38,7 @@ namespace interface1
 {
 Input::Input() : linear_model::training::Input(lastInputId + 1) {}
 Input::Input(const Input & other) : linear_model::training::Input(other) {}
+Input & Input::operator=(const Input & other) = default;
 
 /**
  * Returns an input object for ridge regression model-based training