Skip to content

Commit

Permalink
minor fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
Alexandr-Solovev committed Mar 3, 2025
1 parent 9238928 commit 85bd20f
Show file tree
Hide file tree
Showing 4 changed files with 17 additions and 7 deletions.
2 changes: 1 addition & 1 deletion cpp/oneapi/dal/backend/primitives/sort/sort.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -182,4 +182,4 @@ sycl::event radix_sort_dpl(sycl::queue& queue,

#endif

} // namespace oneapi::dal::backend::primitives
} // namespace oneapi::dal::backend::primitives
2 changes: 1 addition & 1 deletion cpp/oneapi/dal/backend/primitives/sort/sort_dpc.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -654,4 +654,4 @@ INSTANTIATE_RADIX_SORT_WITH_COUNT(std::uint32_t)
INSTANTIATE_RADIX_SORT_WITH_COUNT(std::int64_t)
INSTANTIATE_RADIX_SORT_WITH_COUNT(std::uint64_t)

} // namespace oneapi::dal::backend::primitives
} // namespace oneapi::dal::backend::primitives
8 changes: 3 additions & 5 deletions cpp/oneapi/dal/backend/primitives/sort/test/sort_dpc.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,6 @@
#include "oneapi/dal/test/engine/math.hpp"
#include "oneapi/dal/backend/primitives/sort/sort.hpp"

#include <oneapi/dpl/experimental/kernel_templates>

namespace oneapi::dal::backend::primitives::test {

namespace te = dal::test::engine;
Expand Down Expand Up @@ -76,7 +74,7 @@ class sort_with_indices_test : public te::policy_fixture {
auto ref = create_reference_on_host(val);

INFO("run sort with indices");
auto event = radix_sort_indices_inplace<Float, Index>(this->get_queue(), val, ind);
auto event = radix_sort_indices_inplace<Float, Index>{ this->get_queue() }(val, ind);
event.wait_and_throw();

check_results(val, ind, ref);
Expand Down Expand Up @@ -153,7 +151,7 @@ class sort_test : public te::policy_fixture {
auto val_out = ndarray<Integer, 2>::empty(q, { vector_count, elem_count });

INFO("run sort");
radix_sort<Integer>(this->get_queue(), val, val_out, sorted_elem_count).wait_and_throw();
radix_sort<Integer>{ this->get_queue() }(val, val_out, sorted_elem_count).wait_and_throw();

check_results(val_out, ref, sorted_elem_count);
}
Expand Down Expand Up @@ -203,7 +201,7 @@ TEMPLATE_LIST_TEST_M(sort_with_indices_test,
sort_indices_types) {
SKIP_IF(this->get_policy().is_cpu());

std::int64_t elem_count = GENERATE_COPY(100, 1000, 10000, 100000);
std::int64_t elem_count = GENERATE_COPY(2, 10000);

auto [val, ind] = this->allocate_arrays(elem_count);
this->fill_uniform(val, -25., 25.);
Expand Down
12 changes: 12 additions & 0 deletions docs/source/api/algorithms/ensembles/decision-forest.rst
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,18 @@ splitter_mode::random
and selects the best feature in terms of impurity
computed for that random split from the feature subsets.

`df_engine_types`
~~~~~~~~~~~~~~~

df_engine_types::mt2203
The best splitting strategy chooses the best threshold for each feature while building trees
in terms of impurity among all histogram bins and feature subsets.

df_engine_types::philox
The random splitting strategy chooses a random threshold for each feature while building trees
and selects the best feature in terms of impurity
computed for that random split from the feature subsets.

Descriptor
++++++++++
.. onedal_class:: oneapi::dal::decision_forest::descriptor
Expand Down

0 comments on commit 85bd20f

Please sign in to comment.