Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dev): allow bazel to use different versions of OpenCL lib #3089

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

homksei
Copy link
Contributor

@homksei homksei commented Feb 21, 2025

Description

This pull request updates the Bazel build file for OpenCL dependency to allow the use of different versions of the library.


PR should start as a draft, then move to ready for review state after CI is passed and all applicable checkboxes are closed.
This approach ensures that reviewers don't spend extra time asking for regular requirements.

You can remove a checkbox as not applicable only if it doesn't relate to this PR in any way.
For example, PR with docs update doesn't require checkboxes for performance while PR with any change in actual code should have checkboxes and justify how this code change is expected to affect performance (or justification should be self-evident).

Checklist to comply with before moving PR from draft:

PR completeness and readability

  • I have reviewed my changes thoroughly before submitting this pull request.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes or created a separate PR with update and provided its number in the description, if necessary.
  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • I have added a respective label(s) to PR if I have a permission for that.
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • I have run it locally and tested the changes extensively.
  • All CI jobs are green or I have provided justification why they aren't.
  • I have extended testing suite if new functionality was introduced in this PR.

@homksei homksei force-pushed the chore-dev-bazel-ocllib branch from e5163eb to 4848091 Compare February 21, 2025 11:47
@homksei homksei changed the title chore(dev): multiple versions of OpenCL lib for bazel chore(dev): allow bazel to use different versions of OpenCL lib Feb 21, 2025
@homksei homksei marked this pull request as ready for review February 21, 2025 16:46
@homksei
Copy link
Contributor Author

homksei commented Feb 21, 2025

@mergify backport rls/2025.4.0-rls

Copy link
Contributor

mergify bot commented Feb 21, 2025

backport rls/2025.4.0-rls

🟠 Waiting for conditions to match

  • merged [📌 backport requirement]

@homksei homksei changed the base branch from main to rls/2025.4.0-rls February 26, 2025 14:20
@homksei homksei changed the base branch from rls/2025.4.0-rls to main February 26, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants