Skip to content

Commit 47cdfea

Browse files
committed
refactor: remove executeJs call no needed after component update
1 parent f6772d3 commit 47cdfea

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

enhanced-grid-flow/src/main/java/com/vaadin/componentfactory/enhancedgrid/EnhancedColumn.java

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -132,11 +132,9 @@ private void addFilterButtonToHeader(Component headerComponent, HasValueAndEleme
132132
div.getElement().getStyle().set("display", "inline-block");
133133
filterField.setFor(div.getId().get());
134134
headerComponent.getElement().appendChild(div.getElement());
135-
136-
// this is needed to avoid js issues when adding popup
137-
headerComponent.getElement().executeJs("return").then(ignore -> {
138-
headerComponent.getElement().appendChild(filterField.getElement());
139-
});
135+
136+
// add filter field to header
137+
headerComponent.getElement().appendChild(filterField.getElement());
140138

141139
grid.addFilterClickedEventListener(e -> {
142140
if(e.buttonId.equals(getInternalId())) {

0 commit comments

Comments
 (0)