Skip to content

fix: TreeGridElement#getRowCount #7283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

fix: TreeGridElement#getRowCount #7283

wants to merge 2 commits into from

Conversation

TatuLund
Copy link
Contributor

@TatuLund TatuLund commented Apr 7, 2025

Fixes #7293

@vaadin-bot
Copy link
Collaborator

vaadin-bot commented Apr 7, 2025

TC Format Checker Report - 12:18 - 07 - Apr

BLOCKER There are 1 files with format errors

  • To see a complete report of formatting issues, download the differences file

  • To fix the build, please run mvn spotless:apply in your branch and commit the changes.

  • Optionally you might add the following line in your .git/hooks/pre-commit file:

    mvn spotless:apply
    

Here is the list of files with format issues in your PR:

vaadin-grid-flow-parent/vaadin-grid-testbench/src/main/java/com/vaadin/flow/component/grid/testbench/TreeGridElement.java

Copy link

sonarqubecloud bot commented Apr 7, 2025

@sissbruecker
Copy link
Contributor

Closing as per #7293 (comment)

@TatuLund
Copy link
Contributor Author

TatuLund commented Apr 8, 2025

I would recommend to add convenience scrollToEnd method in TreeGridElement using this, as the need is now obvious:

    public void scrollToEnd() {
            executeScript(
                    "arguments[0].scrollToIndex(...Array(10).fill(Infinity));",
                    this);
    }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TreeGridElement: Method getRowCount() does not always return correct result
3 participants