refactor: update menu-bar submenu to open synchronously #8909
+75
−84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
web-padawan
commented
Apr 4, 2025
| @@ -59,7 +59,6 @@ snapshots["menu-bar basic"] = | |||
| snapshots["menu-bar overlay"] = | |||
| `<vaadin-menu-bar-overlay | |||
| opened="" | |||
| right-aligned="" | |||
There was a problem hiding this comment.
Something was wrong about this snapshot having both right-aligned and start-aligned, seems like the right-aligned was set by __alignOverlayPosition() from ContextMenuMixin since we used to delay setting positionTarget (now it's set synchronously so the above logic doesn't run).
web-padawan
commented
Apr 4, 2025
Comment on lines
-957
to
-962
| // After changing items, buttons are recreated so the old button is | ||
| // no longer in the DOM. Reset position target to null to prevent | ||
| // overlay from closing due to target width / height equal to 0. | ||
| if (overlay.positionTarget && !overlay.positionTarget.isConnected) { | ||
| overlay.positionTarget = null; | ||
| } |
There was a problem hiding this comment.
This was needed before we added initial sync rendering in #8290 - back then, the positionTarget was only set to button after waiting for updateComplete. This is no longer needed, we can set it immediately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Depends on #8908 (this is an independent change but some Tab navigation tests would fail until that PR is merged).
Wrapping opening submenu event with
requestAnimationFrame()was added in vaadin/vaadin-menu-bar#12. It seems unnecessary since there is no need to delay opening overlay (the very first revision at vaadin/vaadin-menu-bar@3bdc279 had an additionalbefore-openevent with some logic, but that was changed in a subsequent commit).Tested this change with Flow components and it seems to make ITs more reliable in terms of timeouts.
Type of change