fix: do not trap focus on item Tab, extract keyboard tests #8912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
commented
Apr 5, 2025
| expect(document.activeElement).to.equal(buttons[1]); | ||
| }); | ||
|
|
||
| it('should switch submenu again on subsequent item Arrow Left', async () => { |
There was a problem hiding this comment.
This test was added in vaadin/vaadin-menu-bar#24 - back then, the logic was a bit different (it was refactored to KeyboardDirectionMixin much later). So maybe it's not needed anymore, however, I decided to keep it and added a similar test for Arrow Right for consistency.
|
vursen
approved these changes
Apr 16, 2025
vaadin-bot
pushed a commit
that referenced
this pull request
Apr 16, 2025
vaadin-bot
pushed a commit
that referenced
this pull request
Apr 16, 2025
web-padawan
added a commit
that referenced
this pull request
Apr 16, 2025
web-padawan
added a commit
that referenced
this pull request
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Based on the finding from #8908 (comment)
keyboard-navigation.test.jsType of change