fix: align icons and buttons in upload file row #8931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sissbruecker
commented
Apr 11, 2025
| @@ -123,6 +123,7 @@ const uploadFile = css` | |||
| [part='commands'] { | |||
| display: flex; | |||
| align-items: baseline; | |||
| align-self: flex-start; | |||
There was a problem hiding this comment.
Maybe we should just change it to use align-items: flex-start everywhere. Using baseline as a default doesn't seem particularly useful for the elements that the upload file row contains.
There was a problem hiding this comment.
It occurred to me that the whole row would be better implemented as a css grid... which we could definitely do in V25, and possibly in a minor.
|
@rolfsmeds Please take a look, I'm not sure if the changes are acceptable as a bugfix for a patch version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently all flex containers in upload file row use
align-items: baseline, which makes it hard to align icons and buttons with the first text line. Changed icons and the commands container that contains buttons to useflex-startinstead. Then applied the same solution we use for aligning icons and buttons with the first line of text in text area.This is potentially a breaking change as it changes default styles, appearance, as well as the default height of the component (it gets a bit smaller).
Fixes #8768
Type of change