refactor!: Base select styles #8944
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
web-padawan
reviewed
Apr 15, 2025
| :host { | ||
| position: relative; | ||
| ::slotted([slot='value']) { | ||
| flex: 1; |
There was a problem hiding this comment.
IIRC setting flex-grow should be enough, no need to change this.
web-padawan
reviewed
Apr 15, 2025
| text-overflow: ellipsis; | ||
| width: 100%; | ||
| line-height: inherit; | ||
| display: contents; |
There was a problem hiding this comment.
We could simply update vaadin-select-value-button template to remove corresponding parts altogether since we are making a breaking change in V25 anyway in terms of styling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New and changed base style properties
--_vaadin-icon-checkmark--_vaadin-icon-chevron-downNew Select base style
Supported custom properties
--vaadin-divider-color<hr>).--vaadin-item-border-radius--vaadin-item-gap--vaadin-item-height--vaadin-item-overlay-padding--vaadin-item-padding