Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add availability annotations to unavailable crypto properties #192

Merged
merged 5 commits into from
Sep 11, 2024

Conversation

ptoffy
Copy link
Member

@ptoffy ptoffy commented Sep 11, 2024

Since adding support for iOS 15, builds started failing at https://swiftpackageindex.com/builds/495EA704-A76E-4078-BAA9-617D0769824E because of an unavailable property (namely compressedRepresentation) which is available from iOS 16 on. This adds annotations to make the property unavailable to iOS 15 (and therefore using Crypto's implementation)

Fixes #191

Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ptoffy looks like my iOS tests aren't working correctly - this should be failing on main. I think I picked an OS that isn't supported judging by the build log.

Could you remove the fixes, get CI to fail and then re-add them?

@ptoffy
Copy link
Member Author

ptoffy commented Sep 11, 2024

Cool @0xTim we should be good

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.28%. Comparing base (3a09049) to head (ec913ba).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #192   +/-   ##
=======================================
  Coverage   83.28%   83.28%           
=======================================
  Files          60       60           
  Lines        1424     1424           
=======================================
  Hits         1186     1186           
  Misses        238      238           
Files with missing lines Coverage Δ
Sources/JWTKit/ECDSA/ECDSAKeyTypes.swift 100.00% <ø> (ø)

@ptoffy ptoffy merged commit 0601ef5 into main Sep 11, 2024
10 checks passed
@ptoffy ptoffy deleted the fix/ios-15-compat branch September 11, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v5 not building for iOS project
2 participants