Fix process kill on Mac OS X Mavericks #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure if I like this solution, did you tested it? |
|
Yes, I tested it and it works for me. I use it for a go-restful project. But I agree on that it is not the most beautiful solution. As I see, #8 can be related to this PR. |
| @@ -46,9 +46,10 @@ def run_go_command! | |||
| @proc = ChildProcess.build(@options[:cmd], "test") | |||
| else | |||
| if @options[:build_only] | |||
| @proc = ChildProcess.build(@options[:cmd], "build") | |||
| @proc = ChildProcess.build options[:cmd], "build", @options[:server] | |||
There was a problem hiding this comment.
Did you mean to remove that @ from the first options?
There was a problem hiding this comment.
You are right. Thanks!
|
I've updated this PR. |
vcastellm
pushed a commit
that referenced
this pull request
Oct 21, 2014
Fix process kill on Mac OS X Mavericks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem:
guard-gogets thepidof thego runcommand and not the pid of the running application. It sends theKILLsignal to thego runprocess and exits, but the child process remains running.The solution: change the application starting process to
go build+./binary.Host: Mac OS X Mavericks
This pull request is based on #10.