Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compression support to Pulsar sink #15143

Closed
zamazan4ik opened this issue Nov 8, 2022 · 3 comments · Fixed by #15519
Closed

Add compression support to Pulsar sink #15143

zamazan4ik opened this issue Nov 8, 2022 · 3 comments · Fixed by #15519
Labels
sink: pulsar Anything `pulsar` sink related type: feature A value-adding code addition that introduce new functionality.

Comments

@zamazan4ik
Copy link
Contributor

A note for the community

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Use Cases

We want to compress messages before sending them to Apache Pulsar.

Attempted Solutions

No response

Proposal

Add compression support to Pulsar sink. Pulsar supports several algorithms.

I guess compression could be implemented in similar way as it's done for Kafka sink.

References

No response

Version

No response

@zamazan4ik zamazan4ik added the type: feature A value-adding code addition that introduce new functionality. label Nov 8, 2022
@jszwedko jszwedko added the sink: pulsar Anything `pulsar` sink related label Nov 8, 2022
@zamazan4ik
Copy link
Contributor Author

Compression could be enabled via https://docs.rs/pulsar/latest/pulsar/producer/struct.ProducerOptions.html#structfield.compression option. Compression routine is already implemented inside pulsar-rs library. We just need to enable it properly.

@zamazan4ik
Copy link
Contributor Author

pulsar-rs does not support tweaking compression levels (yet), so I'ev created the issue in upstream: streamnative/pulsar-rs#239

@zamazan4ik
Copy link
Contributor Author

@bruceg as you mentioned in #14689 Vector decided to go with another approach to handle different compression levels.

Am I right that it also affects the compression level implementation in the Pulsar sink? In this case, I will enable compression with a default level in the Pulsar sink.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sink: pulsar Anything `pulsar` sink related type: feature A value-adding code addition that introduce new functionality.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants