Skip to content

fix(azure service): revert deps bump #23039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 14, 2025
Merged

Conversation

pront
Copy link
Member

@pront pront commented May 13, 2025

Summary

Quote from the issue:
"this introduced a regression transitively from Azure SDK version 0.20.0 that wasn't fixed until 0.22.0:

Issue: Azure/azure-sdk-for-rust#1739
PR: Azure/azure-sdk-for-rust#1997
Fixed in 0.22.0: https://github.com/Azure/azure-sdk-for-rust/commits/azure_identity%400.22.0/
It's worth noting, however, that 0.22.0 introduces its own regression - namely, the removal of EnvironmentCredential from DefaultAzureCredential."

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

How did you test this PR?

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the "no-changelog" label to this PR.

Notes

  • Please read our Vector contributor resources.
  • Do not hesitate to use @vectordotdev/vector to reach out to us regarding this PR.
  • The CI checks run only after we manually approve them.
    • We recommend adding a pre-push hook, please see this template.
    • Alternatively, we recommend running the following locally before pushing to the remote branch:
      • cargo fmt --all
      • cargo clippy --workspace --all-targets -- -D warnings
      • cargo nextest run --workspace (alternatively, you can run cargo test --all)
      • ./scripts/check_changelog_fragments.sh
  • After a review is requested, please avoid force pushes to help us review incrementally.
    • Feel free to push as many commits as you want. They will be squashed into one before merging.
    • For example, you can run git merge origin master and git push.
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run cargo vdev build licenses to regenerate the license inventory and commit the changes (if any). More details here.

References

Ref: #22917

@github-actions github-actions bot added the domain: sinks Anything related to the Vector's sinks label May 13, 2025
@pront
Copy link
Member Author

pront commented May 13, 2025

/ci-run-all

@pront pront changed the title Pront/revert azure deps bump fix(azure service): revert deps bump May 13, 2025
@pront pront added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label May 13, 2025
@datadog-vectordotdev
Copy link

datadog-vectordotdev bot commented May 13, 2025

Datadog Report

Branch report: pront/revert-azure-deps-bump
Commit report: d217720
Test service: vector

❌ 1 Failed (1 Known Flaky), 7 Passed, 0 Skipped, 25.52s Total Time

❌ Failed Tests (1)

  • datadog::logs::validate - vector::e2e - ❄️ Known flaky - Details

    Expand for error
     Test failed, but output was not captured
    

@pront pront requested a review from bfung May 14, 2025 14:55
@pront pront marked this pull request as ready for review May 14, 2025 14:56
@pront pront requested a review from a team as a code owner May 14, 2025 14:56
@pront pront enabled auto-merge May 14, 2025 20:17
Copy link
Member Author

@pront pront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ci-run-integration-azure

@pront pront disabled auto-merge May 14, 2025 20:47
@pront pront merged commit 822ed0d into master May 14, 2025
67 of 73 checks passed
@pront pront deleted the pront/revert-azure-deps-bump branch May 14, 2025 20:48
@pront
Copy link
Member Author

pront commented May 14, 2025

  • Azure IT suite was fixed.
  • AMQP failure is new but unrelated to this PR.
  • E2E failure is known

Had to merge manually since the two unrelated failures blocked this from going to the merge queue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: sinks Anything related to the Vector's sinks no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure SDK version bump introduced regression in token refresh
2 participants