headers: validate CWT claims #210
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pranjal Kole <pranjal.kole7@gmail.com>
pranjalkole
requested review from
henkbirkholz,
OR13,
qmuntal,
roywill,
setrofim,
shizhMSFT,
SimonFrost-Arm,
SteveLasker,
thomas-fossati and
yogeshbdeshpande
as code owners
|
@veraison/go-cose-maintainers, can we get some 👀's on this? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #210 +/- ##
==========================================
- Coverage 92.35% 90.00% -2.36%
==========================================
Files 12 12
Lines 1622 2041 +419
==========================================
+ Hits 1498 1837 +339
- Misses 68 141 +73
- Partials 56 63 +7 ☔ View full report in Codecov by Sentry. |
shizhMSFT
reviewed
Feb 8, 2025
Comment on lines
+126
to
+153
| aud, hasAud := claims[3] | ||
| if hasAud && !canTstr(aud) { | ||
| return claims, errors.New("cwt claim: aud: require tstr") | ||
| } | ||
| exp, hasExp := claims[4] | ||
| if hasExp && !canInt(exp) && !canFloat(exp) { | ||
| return claims, errors.New("cwt claim: exp: require int or float") | ||
| } | ||
| nbf, hasNbf := claims[5] | ||
| if hasNbf && !canInt(nbf) && !canFloat(nbf) { | ||
| return claims, errors.New("cwt claim: nbf: require int or float") | ||
| } | ||
| iat, hasIat := claims[6] | ||
| if hasIat && !canInt(iat) && !canFloat(iat) { | ||
| return claims, errors.New("cwt claim: iat: require int or float") | ||
| } | ||
| cti, hasCti := claims[7] | ||
| if hasCti && !canBstr(cti) { | ||
| return claims, errors.New("cwt claim: cti: require tstr") | ||
| } | ||
| cnf, hasCnf := claims[8] | ||
| if hasCnf && !canMap(cnf) { | ||
| return claims, errors.New("cwt claim: cnf: require map") | ||
| } | ||
| scope, hasScope := claims[9] | ||
| if hasScope && !canBstr(scope) && !canTstr(scope) { | ||
| return claims, errors.New("cwt claim: scope: require bstr or tstr") | ||
| } |
There was a problem hiding this comment.
Instead of having a long list of if statements, can we do something like
for name, value := range claims {
switch name {
case 1: // validate iss
case 2: // validate sub
case 3: // validate aud
// ...
}
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We could also refactor this to a
validateCWTClaimsfunction incwt.go