Skip to content

Test: lint_off waiver for missing file/module not working #6055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

paul-demo
Copy link
Contributor

This worked in Verilator v5.024 to waive missing modules when linting. I check the equivalent example on 5.024 using the older .pl test regress style and the same .vlt file. I believe it broke in 5.028, based on reviewing the relevant commit history. But, I've also now tested it at mainline (2025.05.29, so that is v5.037 I think) and it is now broken and results in an error -- basically the waiver was not respected.

vlt/t_waive_no_module: ==================================================
	export GCOV_PREFIX_STRIP='99'
	export GCOV_PREFIX='/Users/paul-demo/git/verilator/test_regress/obj_dist/gcov_1'
	perl /Users/paul-demo/git/verilator/bin/verilator --prefix Vt_waive_no_module -cc -Mdir obj_vlt/t_waive_no_module --fdedup --debug-check --comp-limit-members 10 --x-assign unique --lint-only -Wall t/t_waive_no_module.vlt --clk clk -f input.vc +define+TEST_OBJ_DIR=obj_vlt/t_waive_no_module +define+TEST_DUMPFILE=obj_vlt/t_waive_no_module/simx.vcd t/t_waive_no_module.v   > obj_vlt/t_waive_no_module/vlt_compile.log
%Error: t/t_waive_no_module.v:15:4: Cannot find file containing module: 'some_module_name'
   15 |    some_module_name #(
      |    ^~~~~~~~~~~~~~~~
        ... See the manual at https://verilator.org/verilator_doc.html?v=5.037 for more assistance.
        ... Looked in:
             t/some_module_name
             t/some_module_name.v
             t/some_module_name.sv
             some_module_name
             some_module_name.v
             some_module_name.sv
             obj_vlt/t_waive_no_module/some_module_name
             obj_vlt/t_waive_no_module/some_module_name.v
             obj_vlt/t_waive_no_module/some_module_name.sv
%Error: Exiting due to 1 error(s)
%Warning: vlt/t_waive_no_module: Exec of verilator failed: %Error: t/t_waive_no_module.v:15:4: Cannot find file containing module: 'some_module_name'
vlt/t_waive_no_module: %Error: Exec of verilator failed: %Error: t/t_waive_no_module.v:15:4: Cannot find file containing module: 'some_module_name'
vlt/t_waive_no_module: FAILED: Exec of verilator failed: %Error: t/t_waive_no_module.v:15:4: Cannot find file containing module: 'some_module_name'
==SUMMARY: Passed 0  Failed 1  Time 0:00

======================================================================
#vlt/t_waive_no_module: %Error: Exec of verilator failed: %Error: t/t_waive_no_module.v:15:4: Cannot find file containing module: 'some_module_name'
		make && test_regress/t/t_waive_no_module.py  --vlt
==TESTS DONE, FAILED: Passed 0  Failed 1  Time 0:00

@paul-demo
Copy link
Contributor Author

Closing since a passing test was added in 8031ca2

@paul-demo paul-demo closed this Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant