Fix tests

Also prepare a point release for npm.
vibbits · Jul 20, 2023 · 8771698 · 8771698
1 parent bf1c85d
commit 8771698
Show file tree

Hide file tree

Showing 4 changed files with 77 additions and 13 deletions.
diff --git a/ChangeLog.md b/ChangeLog.md
@@ -7,6 +7,13 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [3.0.1] - 2023-07-20
+
+### Fixed
+
+- Correct tests and fix a couple bugs that they revealed.
+
+
 ## [3.0.0] - 2023-07-20
 
 ### Added
@@ -41,7 +48,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 Initial release
 
-[unreleased]: https://github.com/vibbits/react-2d-molecule/compare/v3.0.0...HEAD
+[unreleased]: https://github.com/vibbits/react-2d-molecule/compare/v3.0.1...HEAD
+[3.0.1]: https://github.com/vibbits/react-2d-molecule/compare/v3.0.0...v3.0.1
 [3.0.0]: https://github.com/vibbits/react-2d-molecule/compare/v2.0.0...v3.0.0
 [2.0.0]: https://github.com/vibbits/react-2d-molecule/compare/v1.0.2...v2.0.0
 [1.0.2]: https://github.com/vibbits/react-2d-molecule/compare/v1.0.1...v1.0.2

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@vibbioinfocore/react-2d-molecule",
-  "version": "3.0.0",
+  "version": "3.0.1",
   "description": "A React component to display molecule structures in a 2D SVG",
   "browser": "dist/index.js",
   "main": "./dist/index.js",

diff --git a/src/index.tsx b/src/index.tsx
@@ -6,7 +6,7 @@ export type BondVariant =
   | "UNSPECIFIED"
   | "SINGLE"
   | "DOUBLE"
-  | "TRIPPLE"
+  | "TRIPLE"
   | "QUADRUPLE"
   | "QUINTUPLE"
   | "HEXTUPLE"
@@ -354,7 +354,13 @@ const Bonds: React.FC<{ molecule: MoleculeData }> = ({ molecule }) => {
                     <TripleBond key={`triplebond-${i}`} source={f} sink={t} />
                   );
                 case "DOUBLE-EITHERDOUBLE":
-                  return <EitherDoubleBond source={f} sink={t} />;
+                  return (
+                    <EitherDoubleBond
+                      key={`eitherdouble-${i}`}
+                      source={f}
+                      sink={t}
+                    />
+                  );
                 default:
                   return (
                     <UnimplementedBond

diff --git a/test/molecule.test.tsx b/test/molecule.test.tsx
@@ -30,7 +30,7 @@ describe("Molecule component", () => {
         { x: 0, y: 0, element: "C" },
         { x: 10, y: 10, element: "C" },
       ],
-      bonds: [{ atoms: [0, 1], bond: "SINGLE" }],
+      bonds: [{ atoms: [[0, 1, "SINGLE"]] }],
     };
     const { container } = render(<Molecule molecule={data} />);
 
@@ -49,7 +49,45 @@ describe("Molecule component", () => {
         { x: 0, y: 0, element: "Cl" },
         { x: 10, y: 10, element: "Cl" },
       ],
-      bonds: [{ atoms: [0, 1], bond: "DOUBLE" }],
+      bonds: [{ atoms: [[0, 1, "DOUBLE"]] }],
+    };
+    const { container } = render(<Molecule molecule={data} />);
+
+    // chlorine atom labels should  displayed
+    expect(screen.queryAllByText("Cl")).toHaveLength(2);
+
+    // The lines
+    expect(container.querySelectorAll("line")).toHaveLength(2);
+  });
+
+  test("Display a triple bond", () => {
+    const data: MoleculeData = {
+      width: 10,
+      height: 10,
+      atoms: [
+        { x: 0, y: 0, element: "Cl" },
+        { x: 10, y: 10, element: "Cl" },
+      ],
+      bonds: [{ atoms: [[0, 1, "TRIPLE"]] }],
+    };
+    const { container } = render(<Molecule molecule={data} />);
+
+    // chlorine atom labels should  displayed
+    expect(screen.queryAllByText("Cl")).toHaveLength(2);
+
+    // The lines
+    expect(container.querySelectorAll("line")).toHaveLength(3);
+  });
+
+  test("Display an EitherDouble bond", () => {
+    const data: MoleculeData = {
+      width: 10,
+      height: 10,
+      atoms: [
+        { x: 0, y: 0, element: "Cl" },
+        { x: 10, y: 10, element: "Cl" },
+      ],
+      bonds: [{ atoms: [[0, 1, "DOUBLE"]], direction: "EITHERDOUBLE" }],
     };
     const { container } = render(<Molecule molecule={data} />);
 
@@ -68,7 +106,7 @@ describe("Molecule component", () => {
         { x: 0, y: 0, element: "Cl" },
         { x: 10, y: 10, element: "H" },
       ],
-      bonds: [{ atoms: [0, 1], bond: "SINGLE", direction: "BEGINWEDGE" }],
+      bonds: [{ atoms: [[0, 1, "SINGLE"]], direction: "BEGINWEDGE" }],
     };
     const { container } = render(<Molecule molecule={data} />);
 
@@ -88,7 +126,7 @@ describe("Molecule component", () => {
         { x: 0, y: 0, element: "Cl" },
         { x: 10, y: 10, element: "C" },
       ],
-      bonds: [{ atoms: [0, 1], bond: "SINGLE", direction: "BEGINWEDGE" }],
+      bonds: [{ atoms: [[0, 1, "SINGLE"]], direction: "BEGINWEDGE" }],
     };
     const { container } = render(<Molecule molecule={data} />);
 
@@ -108,7 +146,7 @@ describe("Molecule component", () => {
         { x: 0, y: 0, element: "Cl" },
         { x: 5, y: 5, element: "H" },
       ],
-      bonds: [{ atoms: [0, 1], bond: "SINGLE", direction: "BEGINDASH" }],
+      bonds: [{ atoms: [[0, 1, "SINGLE"]], direction: "BEGINDASH" }],
     };
     const { container } = render(<Molecule molecule={data} />);
 
@@ -128,7 +166,7 @@ describe("Molecule component", () => {
         { x: 0, y: 0, element: "Cl" },
         { x: 5, y: 5, element: "C" },
       ],
-      bonds: [{ atoms: [0, 1], bond: "SINGLE", direction: "BEGINDASH" }],
+      bonds: [{ atoms: [[0, 1, "SINGLE"]], direction: "BEGINDASH" }],
     };
     const { container } = render(<Molecule molecule={data} />);
 
@@ -152,7 +190,19 @@ describe("Molecule component", () => {
         { x: 0, y: 2, element: "F" },
         { x: 0, y: 1, element: "F" },
       ],
-      bonds: [{ atoms: [0, 1, 2, 3, 4, 5], bond: "AROMATIC" }],
+      bonds: [
+        {
+          atoms: [
+            [0, 1, "SINGLE"],
+            [1, 2, "DOUBLE"],
+            [2, 3, "SINGLE"],
+            [3, 4, "DOUBLE"],
+            [4, 5, "SINGLE"],
+            [5, 1, "DOUBLE"],
+          ],
+          tag: "RING",
+        },
+      ],
     };
     const { container } = render(<Molecule molecule={data} />);
 
@@ -168,7 +218,7 @@ describe("Molecule component", () => {
       width: 10,
       height: 10,
       atoms: [{ x: 5, y: 5, element: "A" }],
-      bonds: [{ atoms: [], bond: "AROMATIC" }],
+      bonds: [{ atoms: [], tag: "RING" }],
     };
 
     const { container } = render(<Molecule molecule={data} />);
@@ -185,7 +235,7 @@ describe("Molecule component", () => {
         { x: 0, y: 0, element: "Cl" },
         { x: 5, y: 5, element: "H" },
       ],
-      bonds: [{ atoms: [0, 1], bond: "UNSPECIFIED" }],
+      bonds: [{ atoms: [[0, 1, "UNSPECIFIED"]] }],
     };
     render(<Molecule molecule={data} />);