-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improves IPv6 addresses formatting #416
Conversation
b83af85
to
5a738b1
Compare
Thus I also removed support for |
Sounds like the HTTP server code should really operate on the binary representation of the IPv6 address and then just format the last four bytes as IPv4 for robustness. But having the special formatting built-in here definitely makes things nicer in other places, too. Can you maybe just also add a simple unit test to |
Test that is currently implemented already uses use_dns = false. Added resolveHost call with use_dns = true |
Same IPv6 address can be represented by various ways. So we can't rely on any specific format. And there seems to be no such places in Vibe.d
|
b816393
to
8bac4f2
Compare
Sorry, I've missed that the
The binary representation is the same ( |
We have lack of support IPv6 addresses formatting, and especially, IPv4 addresses encapsulated into IPv6
This code is never called and IPv4 addresses on IPv6 interfaces logged as
0:0:0:0:0:ffff:bca2:ee5
instead of::ffff:188.162.14.229
I made own implementation because
inet_ntop
from glibc internally does redundand buffer copying, uses stringz, errno and not handlesrare::2
address case