-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.0.0 --> v1.4.1 #12
Conversation
Hey @mccraveiro - I just noticed the README.md would need updating too: Line 8 in 7527714
I missed that when I did the 0.33.0 --> v1.0.0 bump 🤦 |
@Jabbslad thanks for pointing that out. Just fixed it :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know when or if the repository owner will reply but a version bump to the newest version is the next step (1.5.x). Further, maybe it would be useful to update to a 24.05 as 23.10 is deprecated. An alternative solution would be to use unstable and allow the importer to use gleam-nix.inputs.nixpkgs.follows = "nixpkgs"
?
@@ -60,13 +60,15 @@ | |||
fmt = flake-utils.lib.mkApp { | |||
drv = with pkgs; | |||
writeScriptBin "fmt" '' | |||
#!/bin/bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would remove that as the assumption of /bin/bash
is not guaranteed. I think only shell is always available.
One should replace the writeScriptBin
with writeShellScriptBin
. Accordingly the #!/bin/bash
is not required and the correct shell runtime is populated.
https://nixos.org/manual/nixpkgs/unstable/#trivial-builder-writeShellScriptBin
@@ -5,7 +5,7 @@ | |||
# If you already have Nix installed, try Gleam right away by using: | |||
$ nix shell github:vic/gleam-nix | |||
$ gleam --version | |||
gleam <a href="https://github.com/gleam-lang/gleam/releases/v0.33.0">0.33.0</a> | |||
gleam <a href="https://github.com/gleam-lang/gleam/releases/v1.4.1">1.4.1</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why bother updating the reference? It shows an example output of the gleam executable. Personally, I would remove the link or point to the repository, as keeping the reference up-to-date is unnecessary work which is quickly forgotten.
Hi, Sorry for the very late response. I was away from computers living another life :). I've re-written how this flake works. We no longer bundle There's also a wiki page where we can keep track of Gleam version ranges. This repo tags still try to follow the first Gleam tag that was able to build when the rust version needs to change. I'm closing this since now v1.4.1 -> v1.9.1 are now buildable with current branch. |
Close #11
#!/bin/bash
to bin scripts