Skip to content

Commit afc7d40

Browse files
authored
Update test-app and addon to latest blueprint (#80)
* Run `npx ember-cli-update --from=3.17 --to=4.9.2` to sync test-app blueprint * update addon blueprint
1 parent 3b51535 commit afc7d40

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

44 files changed

+3430
-3998
lines changed

.github/workflows/ci.yml

+18-10
Original file line numberDiff line numberDiff line change
@@ -15,22 +15,27 @@ jobs:
1515
test:
1616
name: "Tests"
1717
runs-on: ubuntu-latest
18+
timeout-minutes: 10
1819

1920
steps:
20-
- uses: actions/checkout@v2
21+
- uses: actions/checkout@v3
2122
- name: Install Node
2223
uses: actions/setup-node@v3
2324
with:
2425
node-version: 14.x
2526
cache: yarn
27+
2628
- name: Install Dependencies
2729
run: until yarn install --frozen-lockfile; do echo "Retrying yarn"; done
30+
2831
- name: Lint Addon
2932
run: yarn lint
30-
working-directory: addon
33+
working-directory: ember-engines-router-service
34+
3135
- name: Lint Test App
3236
run: yarn lint
3337
working-directory: test-app
38+
3439
- name: Run Tests
3540
run: yarn test:ember
3641
working-directory: test-app
@@ -40,15 +45,17 @@ jobs:
4045
runs-on: ubuntu-latest
4146

4247
steps:
43-
- uses: actions/checkout@v2
48+
- uses: actions/checkout@v3
4449
- uses: actions/setup-node@v3
4550
with:
4651
node-version: 14.x
4752
cache: yarn
53+
4854
- name: Install Dependencies
4955
# Absurdly, yarn always fails on the first try here.
5056
# https://github.com/yarnpkg/yarn/issues/2629
5157
run: until yarn install --no-lockfile; do echo "Retrying yarn"; done
58+
5259
- name: Run Tests
5360
run: yarn test:ember
5461
working-directory: test-app
@@ -62,28 +69,29 @@ jobs:
6269
fail-fast: false
6370
matrix:
6471
try-scenario:
65-
# - ember-lts-3.12
66-
- ember-lts-3.16
67-
- ember-lts-3.20
6872
- ember-lts-3.24
6973
- ember-lts-3.28
70-
# - ember-release
71-
# - ember-beta
72-
# - ember-canary
74+
- ember-lts-4.4
75+
- ember-lts-4.8
76+
- ember-release
77+
- ember-beta
78+
- ember-canary
7379
- ember-default-with-jquery
7480
- ember-classic
7581
# - embroider-safe
7682
# - embroider-optimized
7783

7884
steps:
79-
- uses: actions/checkout@v2
85+
- uses: actions/checkout@v3
8086
- name: Install Node
8187
uses: actions/setup-node@v3
8288
with:
8389
node-version: 14.x
8490
cache: yarn
91+
8592
- name: Install Dependencies
8693
run: until yarn install --frozen-lockfile; do echo "Retrying yarn"; done
94+
8795
- name: Run Tests
8896
run: ./node_modules/.bin/ember try:one ${{ matrix.try-scenario }}
8997
working-directory: test-app

addon/.gitignore

-26
This file was deleted.

addon/.npmignore

-13
This file was deleted.

addon/.prettierignore

-25
This file was deleted.

addon/.template-lintrc.js

-5
This file was deleted.

addon/config/environment.js

-5
This file was deleted.

addon/.eslintignore ember-engines-router-service/.eslintignore

-10
Original file line numberDiff line numberDiff line change
@@ -4,22 +4,12 @@
44

55
# compiled output
66
/dist/
7-
/tmp/
87

98
# dependencies
10-
/bower_components/
119
/node_modules/
1210

1311
# misc
1412
/coverage/
1513
!.*
1614
.*/
1715
.eslintcache
18-
19-
# ember-try
20-
/.node_modules.ember-try/
21-
/bower.json.ember-try
22-
/package.json.ember-try
23-
24-
# type definitions
25-
*.d.ts

addon/.eslintrc.js ember-engines-router-service/.eslintrc.js

+1-15
Original file line numberDiff line numberDiff line change
@@ -23,16 +23,7 @@ module.exports = {
2323
overrides: [
2424
// node files
2525
{
26-
files: [
27-
'./.eslintrc.js',
28-
'./.prettierrc.js',
29-
'./.template-lintrc.js',
30-
'./ember-cli-build.js',
31-
'./addon-main.js',
32-
'./testem.js',
33-
'./blueprints/*/index.js',
34-
'./config/**/*.js',
35-
],
26+
files: ['./.eslintrc.js', './.prettierrc.js', './addon-main.js'],
3627
parserOptions: {
3728
sourceType: 'script',
3829
},
@@ -43,10 +34,5 @@ module.exports = {
4334
plugins: ['node'],
4435
extends: ['plugin:node/recommended'],
4536
},
46-
{
47-
// test files
48-
files: ['tests/**/*-test.{js,ts}'],
49-
extends: ['plugin:qunit/recommended'],
50-
},
5137
],
5238
};
+15
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
# unconventional js
2+
/blueprints/*/files/
3+
/vendor/
4+
5+
# compiled output
6+
/dist/
7+
8+
# dependencies
9+
/node_modules/
10+
11+
# misc
12+
/coverage/
13+
!.*
14+
.*/
15+
.eslintcache
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
# unconventional js
2+
/blueprints/*/files/
3+
/vendor/
4+
5+
# compiled output
6+
/dist/
7+
8+
# dependencies
9+
/node_modules/
10+
11+
# misc
12+
/coverage/
13+
!.*
14+
.eslintcache
15+
.lint-todo/
File renamed without changes.
File renamed without changes.
File renamed without changes.

addon/package.json ember-engines-router-service/package.json

+26-21
Original file line numberDiff line numberDiff line change
@@ -16,35 +16,44 @@
1616
"./*": "./dist/*",
1717
"./addon-main.js": "./addon-main.js"
1818
},
19+
"typesVersions": {
20+
"*": {
21+
"*": [
22+
"types/*"
23+
]
24+
}
25+
},
1926
"files": [
2027
"addon-main.js",
2128
"dist",
2229
"types"
2330
],
2431
"scripts": {
2532
"build": "rollup --config",
26-
"prepublishOnly": "rollup --config",
27-
"start": "rollup --config --watch",
2833
"lint": "eslint . --cache",
29-
"lint:fix": "eslint . --fix"
34+
"lint:fix": "eslint . --fix",
35+
"prepublishOnly": "rollup --config",
36+
"start": "rollup --config --watch"
3037
},
3138
"dependencies": {
32-
"@embroider/addon-shim": "^1.2.0"
39+
"@embroider/addon-shim": "^1.8.4"
3340
},
3441
"devDependencies": {
35-
"@babel/core": "^7.17.8",
36-
"@babel/plugin-proposal-class-properties": "^7.16.7",
37-
"@babel/plugin-proposal-decorators": "^7.17.8",
38-
"@embroider/addon-dev": "^1.2.0",
39-
"@rollup/plugin-babel": "^5.3.1",
40-
"@types/ember__routing": "^4.0.10",
41-
"eslint": "^8.11.0",
42+
"@babel/core": "^7.20.7",
43+
"@babel/eslint-parser": "^7.19.1",
44+
"@babel/plugin-proposal-class-properties": "^7.18.6",
45+
"@babel/plugin-proposal-decorators": "^7.20.7",
46+
"@embroider/addon-dev": "^3.0.0",
47+
"@rollup/plugin-babel": "^6.0.3",
48+
"@types/ember__routing": "^4.0.12",
49+
"ember-cli-htmlbars": "^6.1.1",
50+
"eslint": "^8.30.0",
4251
"eslint-config-prettier": "^8.5.0",
43-
"eslint-plugin-ember": "^10.5.9",
52+
"eslint-plugin-ember": "^11.3.1",
4453
"eslint-plugin-node": "^11.1.0",
45-
"eslint-plugin-prettier": "^4.0.0",
46-
"prettier": "^2.6.0",
47-
"rollup": "^2.70.1"
54+
"eslint-plugin-prettier": "^4.2.1",
55+
"prettier": "^2.8.1",
56+
"rollup": "^3.8.1"
4857
},
4958
"engines": {
5059
"node": "14.* || 16.* || >= 18"
@@ -77,11 +86,7 @@
7786
"./services/engine-router-service.js": "./dist/_app_/services/engine-router-service.js"
7887
}
7988
},
80-
"typesVersions": {
81-
"*": {
82-
"*": [
83-
"types/*"
84-
]
85-
}
89+
"volta": {
90+
"extends": "../package.json"
8691
}
8792
}
File renamed without changes.
File renamed without changes.

package.json

+12-12
Original file line numberDiff line numberDiff line change
@@ -6,33 +6,33 @@
66
"url": "https://github.com/villander/ember-engines-router-service"
77
},
88
"workspaces": [
9-
"addon",
9+
"ember-engines-router-service",
1010
"test-app"
1111
],
1212
"scripts": {
13-
"prepare": "cd addon && yarn build",
13+
"prepare": "cd ember-engines-router-service && yarn build",
1414
"release": "release-it"
1515
},
1616
"devDependencies": {
17-
"release-it": "^14.13.1",
18-
"release-it-lerna-changelog": "^4.0.1",
19-
"release-it-yarn-workspaces": "^2.0.1"
17+
"release-it": "^15.5.1",
18+
"@release-it-plugins/lerna-changelog": "^5.0.0",
19+
"@release-it-plugins/workspaces": "^3.2.0"
2020
},
2121
"publishConfig": {
2222
"registry": "https://registry.npmjs.org"
2323
},
2424
"release-it": {
2525
"hooks": {
26-
"before:init": "cp README.md LICENSE.md addon/"
26+
"before:init": "cp README.md LICENSE.md ember-engines-router-service/"
2727
},
2828
"plugins": {
29-
"release-it-lerna-changelog": {
29+
"@release-it-plugins/lerna-changelog": {
3030
"infile": "CHANGELOG.md",
3131
"launchEditor": false
3232
},
33-
"release-it-yarn-workspaces": {
33+
"@release-it-plugins/workspaces": {
3434
"workspaces": [
35-
"addon"
35+
"ember-engines-router-service"
3636
],
3737
"additionalManifests": {
3838
"dependencyUpdates": [
@@ -55,7 +55,7 @@
5555
"npm": false
5656
},
5757
"volta": {
58-
"node": "14.19.2",
59-
"yarn": "1.22.18"
58+
"node": "14.21.2",
59+
"yarn": "1.22.19"
6060
}
61-
}
61+
}

test-app/.ember-cli

+7-1
Original file line numberDiff line numberDiff line change
@@ -5,5 +5,11 @@
55

66
Setting `disableAnalytics` to true will prevent any data from being sent.
77
*/
8-
"disableAnalytics": false
8+
"disableAnalytics": false,
9+
10+
/**
11+
Setting `isTypeScriptProject` to true will force the blueprint generators to generate TypeScript
12+
rather than JavaScript by default, when a TypeScript version of a given blueprint is available.
13+
*/
14+
"isTypeScriptProject": false
915
}

0 commit comments

Comments
 (0)