Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Menu Drop Down fixed for Bigger Screens #914

Merged
merged 1 commit into from
Oct 18, 2024
Merged

[FIX] Menu Drop Down fixed for Bigger Screens #914

merged 1 commit into from
Oct 18, 2024

Conversation

4F24L
Copy link
Collaborator

@4F24L 4F24L commented Oct 18, 2024

Menu Drop Down Added

Description

  • Menu dropdown Button Should be open for smaller screens. not for all screens.

Screenshots (if applicable)

image

image

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the contributing document.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added necessary tests to ensure my changes are effective.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

Copy link

vercel bot commented Oct 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bobble-ai-rcmb ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2024 5:45am

Copy link

👋 Thank you for opening this pull request! We're excited to review your contribution. Please give us a moment, and we'll get back to you shortly!

Feel free to join our community on Discord to discuss more!

@github-actions github-actions bot requested a review from vimistify October 18, 2024 05:45
@4F24L 4F24L changed the title Menu Drop Down fixed for Bigger Screens [FIX] Menu Drop Down fixed for Bigger Screens Oct 18, 2024
@4F24L 4F24L self-assigned this Oct 18, 2024
@4F24L 4F24L merged commit e7b1880 into vimistify:main Oct 18, 2024
4 checks passed
Copy link

🚀 Thank you for your contribution! This pull request has been closed. If you have any questions or need further assistance, feel free to reach out.

@4F24L
Copy link
Collaborator Author

4F24L commented Oct 19, 2024

Can you please add at least level 1 to these PRs? As these are the genuine issues that I raised and solved. @MastanSayyad

Copy link
Collaborator

@MastanSayyad MastanSayyad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is nothing genuine with these Contributions, i removed labels after reviewing the code, these are minor css changes and mostly added display: none; and you added level 3 for this, anything that is merged by you will have zero labelings

I have kept 3-4 PRs with labels while others with none. We have already told so many times that a Contributor cant be a PA or a maintainer, and you have been misusing it.

It's your responsibility to inform us before doing such practices.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Menu Bar Issue In Bigger Screen
2 participants