Skip to content

Commit

Permalink
refactor: xmltodict is only test dependency (#124)
Browse files Browse the repository at this point in the history
  • Loading branch information
Vinit Kumar authored Apr 23, 2022
1 parent 6aafca8 commit 33a3706
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 12 deletions.
7 changes: 1 addition & 6 deletions .github/workflows/pythonpackage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,16 +30,11 @@ jobs:
python -m pip install --upgrade pip
pip install pytest
pip install -r requirements.txt
python setup.py install
- name: Lint with flake8
run: |
pip install flake8
pip install xmltodict==0.12.0
pip install pytest==7.0.1
pip install coverage==6.3.2
pip install py==1.11.0
# stop the build if there are Python syntax errors or undefined names
flake8 json2xml/ --exit-zero
python setup.py install
- name: Unit tests
run: |
coverage run -m pytest
Expand Down
7 changes: 4 additions & 3 deletions README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -197,9 +197,10 @@ This is provided by pytest, which is straight forward.

.. code-block:: bash
python3.8 -mvenv venv
source venv/bin/activate
python setup.py test
virtualenv venv -p $(which python3.9)
pip install -r requirements-dev.txt
python setup.py install
pytest
Credits
Expand Down
5 changes: 5 additions & 0 deletions requirements-dev.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
-r requirements.txt
xmltodict==0.12.0
pytest==7.0.1
coverage==6.3.2
py==1.11.0
1 change: 0 additions & 1 deletion requirements.in
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
requests>=2.20.0
defusedxml==0.7.1
xmltodict

2 changes: 0 additions & 2 deletions requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,3 @@ requests==2.26.0
# via -r requirements.in
urllib3==1.26.7
# via requests
xmltodict==0.12.0
# via -r requirements.in

0 comments on commit 33a3706

Please sign in to comment.