-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add BeforeStep / AfterStep hooks #281
add BeforeStep / AfterStep hooks #281
Conversation
edbcee2
to
ae7e1aa
Compare
Let's add a test for step hooks in a new folder |
I added regarding enabling page fixture in addition to common |
I've updated |
I found that I haven't changed |
I've pushed the fix for passing fixtures to step hooks, on top of your last commit. Are you willing to contribute to the docs as well? |
Working on it. Will push something ASAP |
I wasn't aware that tagging exist, so I'm unsure whether I got that part of the documentation right. Would you mind double-checking the contents are accurate? |
.prototools
Outdated
@@ -0,0 +1,2 @@ | |||
node = "~20" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this file for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad. I should have left this file out of the commit. It's to specify that this repo uses node 20 for this tool https://moonrepo.dev/proto
@the3dsandwich in your scenario with screenshots, if step fails do you expect the |
Co-authored-by: Vitaliy Potapov <potapov.vitaliy@gmail.com>
I personally do not expect |
I updated the docs a bit further, so that the example of taking a screenshot after every step is in the |
Co-authored-by: Vitaliy Potapov <potapov.vitaliy@gmail.com>
As discussed in #280
The
BeforeStep
andAfterStep
hooks will enable code to be run before eachGiven
,When
,Then
, etc. steps.This way, we will be able to attach screenshots for every step.