forked from elastic/kibana
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution][Detection Engine] initial commit #12
Open
vitaliidm
wants to merge
162
commits into
de_8_18/adds-logged-requests
Choose a base branch
from
de_8_19/preview-logged-requests-IM
base: de_8_18/adds-logged-requests
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Security Solution][Detection Engine] initial commit #12
vitaliidm
wants to merge
162
commits into
de_8_18/adds-logged-requests
from
de_8_19/preview-logged-requests-IM
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Summary This PR covers required updates for EUI refresh: [elastic#11228](elastic/security-team#11228) The updates should only cover Entity Owned components. ### Severity Colors Blocked Severity colors are on hold until the security severity color palette is finalised. Once agreed, a shared hook will be updated across all of security, replacing the current RISK_SEVERITY_COLOUR mapping. The previous severity colors hook was reverted in preparation for this change. Updates for EA will be tracked accordingly. See https://elastic.slack.com/archives/C0851RDCWPP/p1736954935896329 for more details elastic/security-team#11516 elastic#206276 --- ### Testing Running Kibana with the Borealis theme In order to run Kibana with Borealis, you'll need to do the following: 1. Set the following in kibana.dev.yml: u`iSettings.experimental.themeSwitcherEnabled: true` 2. Run Kibana with the following environment variable set: `KBN_OPTIMIZER_THEMES="borealislight,borealisdark,v8light,v8dark" yarn start` 3. This will expose a toggle under **Stack Management > Advanced Settings > Theme version**, which you can use to toggle between Amsterdam and Borealis. --- More details about each section elastic#199715 #### Borealis Updates Light & Dark Theme ### Screenshots Google Docs for easy read - same screenshots below https://docs.google.com/document/d/1tKPoqCPbccX94cqgPyHKBdr9_K3kmqveQGkcGo_Q8k4/edit?usp=sharing --- ## Light Theme ### Entity Store   ### Risk Score  ### Dashboard and Flyout     ## Dark Theme ### Entity Store   ### Risk Score  ### Dashboard and Flyout     --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Mark Hopkin <mark.hopkin@elastic.co>
## Summary Quick fix changing a telemetry ID.
## Summary Resolves elastic#207340 ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ### Release note Removed deprecated get user actions API --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
…#206662) Adds the observability onboarding landing page to global search. Keywords used: - `Add data` <img width="651" alt="image" src="https://github.com/user-attachments/assets/9a88b24d-ee85-495e-99be-812428e829c1" /> <img width="661" alt="image" src="https://github.com/user-attachments/assets/72fe9848-3b4b-4975-a824-4c8a4e89665d" /> Closes elastic#190715 --------- Co-authored-by: Joe Reuter <johannes.reuter@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
## Summary As K8S Dashboard is currently hidden on main , the code serves no purpose other than potentially causing Tech debts whenever a refactor or a migration happens. As such its better to remove it completely. In case we want to bring it back later we will just pull it from git history > [!CAUTION] > **This should only affect Serverless and Main, 8.x.x should still be able to see and access K8S Dashboard** ## Related Tickets - elastic/security-team#11418 - elastic/security-team#10735 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Paulo Silva <paulo.henrique@elastic.co> Co-authored-by: Maxim Kholod <maxim.kholod@elastic.co>
This PR contains the following updates: | Package | Type | Update | Change | Pending | |---|---|---|---|---| | [@xyflow/react](https://reactflow.dev) ([source](https://togithub.com/xyflow/xyflow/tree/HEAD/packages/react)) | dependencies | patch | [`^12.4.0` -> `^12.4.1`](https://renovatebot.com/diffs/npm/@xyflow%2freact/12.4.2/12.4.1) | `12.4.2` | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjUuMSIsInVwZGF0ZWRJblZlciI6IjM3LjQyNS4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJUZWFtOkNsb3VkIFNlY3VyaXR5IiwiYmFja3BvcnQ6YWxsLW9wZW4iLCJyZWxlYXNlX25vdGU6c2tpcCJdfQ==--> Co-authored-by: elastic-renovate-prod[bot] <174716857+elastic-renovate-prod[bot]@users.noreply.github.com> Co-authored-by: Maxim Kholod <maxim.kholod@elastic.co>
…stic#207748) Closes elastic#101007 ## Summary **Double-checked with ES that can be removed** In the policies tab, when two policies had the same schedule, we were displaying a banner warning that only one snapshot could be taken at a time, although this is no longer true. This PR removes that banner. <img width="1068" alt="Screenshot 2025-01-22 at 13 15 55" src="https://github.com/user-attachments/assets/cdb7d468-5ef1-4acd-8ea6-4ce961453695" /> ## How to test Run Elasticsearch adding the file system path you want to use for the repo: ``` yarn es snapshot --license=trial -E path.repo=/tmp/es-backups ``` From the console, you can add a repository pointing the location you previously specified: ``` PUT /_snapshot/my_backup { "type": "fs", "settings": { "location": "/tmp/es-backups", "chunk_size": "10mb" } } ``` Now, create at least two policies with the same schedule: ``` PUT _slm/policy/policy-1 { "schedule": "0 20 11 * * ?", "name": "<policy-1-{now/d}>", "repository": "my_backup", "config": { "indices": ["*"], "ignore_unavailable": false, "include_global_state": true } } PUT _slm/policy/policy-2 { "schedule": "0 20 11 * * ?", "name": "<policy-2-{now/d}>", "repository": "my_backup", "config": { "indices": ["*"], "ignore_unavailable": false, "include_global_state": true } } ``` Navigate to Snapshot and Restore > Policies > And verify the banner is not longer displayed despite the policies have the same schedule. You can also schedule the policies a couple of minutes after their creation and verify that the snapshots are taken at the same time without any problem.
## Summary The new Connectors and Web Crawler icons were redesigned and will be provided by EUI with [this PR](elastic/eui#8285). While those are not available waiting for next EUI release, [we agreed with EUI team](https://elastic.slack.com/archives/C7QC1JV6F/p1737712560812099) to update any reference with custom EUI icons in the meantime to later get them from EUI and remove this custom implementation.    ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ...
## Summary Closes elastic#205844 When querying agent ids for actions, some agent ids might not be in `.fleet-actions`, but only in `.fleet-actions-results`. This happens when during the bulk upgrade action, some agents are not upgradeable, the agents only appear in `.fleet-actions-results` as errors. So as a fix, querying agent ids from there too. To verify: - enroll a few agents with docker - select 2 or more agents - click bulk upgrade action - open agent activity, find the failed action - click on `View agents` - verify that the agents are filtered correctly <img width="1161" alt="image" src="https://github.com/user-attachments/assets/344b6b1f-0f4c-48ec-98c5-15df46b6b227" /> <img width="727" alt="image" src="https://github.com/user-attachments/assets/fb4a9fdb-5e62-448c-a4f4-6ba127bdfdd6" /> <img width="1165" alt="image" src="https://github.com/user-attachments/assets/ee29469b-4b67-4ed7-9716-a5d8ac25d37a" /> ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
…ic#208347) As requested, changed  to 
## Summary Attempt at fixing the following failing serverless test suite: `src/core/server/integration_tests/saved_objects/serverless/migrations/actions.test.ts` Resulting in `write EPIPE` See incident 1077
…re status page (elastic#208149) ## Summary Add "Install" and "Reinstall" buttons on Entity Store status page * It also adds an extra loading state for the 'enable' switch in the header  ### How to test it? **1)** * Start a Kibana repository with entity data * Install the entity store * Delete one engine using Dev Tools `DELETE kbn:/api/entity_store/engines/user` * Go to the manage entity store status tab * Verify that it displays an install button for the uninstalled engine * Install the engine **2)** * Start a Kibana repository with entity data * Install the entity store * Go to the manage entity store status tab * Delete one component of an installed engine (transform) * Go to the manage entity store status tab * Verify it displays a reinstall button for the engine you uninstalled the component * Reinstall the engine * Everything should look ok * Extra step: Verify if there was any data lost after reinstalling the engine ### Checklist Reviewers should verify this PR satisfies this list as well. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
…ic license (elastic#208359) ## Summary `get_all` suite `x-pack/test/spaces_api_integration/security_and_spaces/apis/get_all.ts` is intented to be run only with `basic` license, since FIPS overrides it we need to skip that test for FIPS. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
…and banner (elastic#205785) ## Summary > [!warning] > Planned to be merged before feature freeze, to cause the smallest reasonable diverge between serverless and ess. - adds advanced option `aggregate_network` - adds advanced option `allow_cloud_features` - re-adds backfill for existing data collection reduction advanced options - and updates their default value in their descriptions - reenables banner for informing users, but it's kept behind a feature flag: `xpack.securitySolution.enableExperimental.eventCollectionDataReductionBannerEnabled` - bumps revision number to trigger re-deployment of policies > [!note] > To enable the banner, set the feature flag `xpack.securitySolution.enableExperimental.eventCollectionDataReductionBannerEnabled` ### Stack upgrade test #### Before upgrade <img width="191" alt="Screenshot 2025-01-07 at 17 41 31" src="https://github.com/user-attachments/assets/41fdf96b-e105-4d6a-bd58-2cd916ba4267" /> <img width="675" alt="Screenshot 2025-01-07 at 17 42 01" src="https://github.com/user-attachments/assets/a0af8d6c-dc6a-486b-a588-0a59f73460fd" /> #### After upgrade <img width="198" alt="Screenshot 2025-01-07 at 17 43 52" src="https://github.com/user-attachments/assets/98806068-3a3f-4cf1-855c-01b5953bca9c" /> <img width="699" alt="Screenshot 2025-01-07 at 17 44 45" src="https://github.com/user-attachments/assets/12934b78-7679-427b-903d-208773c8086f" /> /* this is only for one OS, but the values are backfilled for all 3 OSes ### Banner <img width="1384" alt="image" src="https://github.com/user-attachments/assets/9505f5d0-5cd6-4ea1-b70c-3d5f4888d4f2" /> ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Daniel Ferullo <56368752+ferullo@users.noreply.github.com>
…stic#207089) ## Summary This PR adds StdPerf to the alerts page and alert details page only for the overview tab. |Page|Screenshot| |---|---| |Alerts page|| |Alert details page|| --- Resolves elastic/observability-dev#3559 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
## Summary Part of elastic/kibana-team#1417 Replaces scss with emotion in the ES|QL editor --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
### Summary For migration purposes, we need to remove complex tables in the docs. If we ultimately decide that we need complex tables to support certain documentation use-cases, we can add that functionality to docs-builder later. For elastic/docs-builder#112 (comment). Co-authored-by: florent-leborgne <florent.leborgne@elastic.co>
Closes elastic/observability-dev#4236 🔒 This change: * Moves flow progress update telemetry events to the backend (this will prevent situations when multiple progress updates happened in a short time interval, but frontend could only see the latest update because it checks for progress once in a few seconds which might not be enough in some situations) * Leaves the data_ingested final event on the FE because it's not explicitly triggered on the BE * Deletes a separate event type for auto detect flow in favor of the generic even used by other flows * Adds progress updates to the auto-detect script when when it's being run on unsupported OS or lsof binary is not present * Adds logging of the OS and architecture used by the host Events coming from your local Kibana can viewed on the [🔒 Staging Telemetry cluster](https://telemetry-v2-staging.elastic.dev). Though keep in mind, there is a ~1 hour delay for events indexing 😔 Example event: 
## Summary Resolves elastic#207341 ### Checklist Check the PR satisfies following conditions. - [x] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ### Release note Removed deprecated get case status API --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
…#207429) ## Summary Fixes an issue that caused the body scroll to jump when clicking options in the Lens inline editor flyout. Fixes elastic#201544 This issue was created when we added the `autoFocus` option to the `EuiSelectable` for the dataview picker and the chart type picker. This appears to be an issue with how eui is handling the `autoFocus`, see elastic/eui#8287. In the meantime this is a workaround to prevent this scroll jumping while also keeping the auto focus behavior. https://github.com/user-attachments/assets/94256fa7-f6bd-4943-91f6-42201ce4ab74 ### Checklist - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) ## Release note Fixes and issue in Dashboards with the Lens inline editor where the dashboard would scroll to the top when interacting with the Lens editor flyout. --------- Co-authored-by: Marta Bondyra <4283304+mbondyra@users.noreply.github.com>
…efresh (elastic#208114) Fixes elastic#201269 ## Summary * Extracts the usage of the EMS styles identifiers to always refer to the constants at `ems_defaults.ts` * Adds logic in the Vega and Maps plugins to resolve different styles depending on the theme, bringing the new `road_map_desaturated_v9` and `dar_kmap_v9` styles when Borealis theme is enabled. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - Screenshots will be updated as a larger effort afterwards. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - Changes were small enough for this to not require new tests. - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. ## Release note Elastic Maps Service basemaps shown in the Custom Visualization component (Vega) and in the Maps application and components alighn with the new dark and light theme. --------- Co-authored-by: Nick Partridge <nick.ryan.partridge@gmail.com>
## Summary We forgot to update this privilege in elastic#201780 . The endpoint only uses the scoped SO client, so this missing privilege declaration does not lead to privilege escalation on the endpoint. There are automated tests that check for the correct privilege access for this and other endpoints.
## Summary This PR fixes a bug that was introduced in elastic#206941 (by my recommendation, oops) where panels can no longer be reset on Dashboard. **Before** https://github.com/user-attachments/assets/90bfce89-e188-45c6-937d-9ad48982d387 **After** https://github.com/user-attachments/assets/25c9b9c8-7ad5-4808-89a1-0dcf7921b52e ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
Resolves [elastic#207879](elastic#207879) This PR separates the different SLO route functions into separate files, each with a single responsibility. The functions are still exported via a single function, `getSloRouteRepository`. --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
## Summary Removing LogStream component from `enterprise_search` plugin and it is no longer used with the removal of App Search & Workplace Search. Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
…t@18 (elastic#208387) ## Summary Part of elastic#206952 Fixes when run with React@18 elastic#208339 (comment): [[job]](https://buildkite.com/elastic/kibana-pull-request/builds/270417#0194a78a-2649-4cd6-bac8-5f186c246055) [[logs]](https://buildkite.com/organizations/elastic/pipelines/kibana-pull-request/builds/270417/jobs/0194a78a-2649-4cd6-bac8-5f186c246055/artifacts/0194a7ae-4701-478b-93ef-9013f7210234) Jest Integration Tests / request flyout renders _meta field [[job]](https://buildkite.com/elastic/kibana-pull-request/builds/270417#0194a78a-2649-4cd6-bac8-5f186c246055) [[logs]](https://buildkite.com/organizations/elastic/pipelines/kibana-pull-request/builds/270417/jobs/0194a78a-2649-4cd6-bac8-5f186c246055/artifacts/0194a7ae-4702-4357-a67e-d59c6bb5f12b) Jest Integration Tests / request flyout renders a json with default policy name when only policy name is missing [[job]](https://buildkite.com/elastic/kibana-pull-request/builds/270417#0194a78a-2649-4cd6-bac8-5f186c246055) [[logs]](https://buildkite.com/organizations/elastic/pipelines/kibana-pull-request/builds/270417/jobs/0194a78a-2649-4cd6-bac8-5f186c246055/artifacts/0194a7ae-4701-4d18-8c34-1f4965486aa1) Jest Integration Tests / request flyout renders an error callout if policy form is invalid [[job]](https://buildkite.com/elastic/kibana-pull-request/builds/270417#0194a78a-2649-4cd6-bac8-5f186c246055) [[logs]](https://buildkite.com/organizations/elastic/pipelines/kibana-pull-request/builds/270417/jobs/0194a78a-2649-4cd6-bac8-5f186c246055/artifacts/0194a7ae-4701-4533-9e12-e7056e8277aa) Jest Integration Tests / request flyout renders the correct json and name for a new policy To run with React@18 use: ``` REACT_18=true yarn test:jest_integration x-pack/platform/plugins/private/index_lifecycle_management/integration_tests/edit_policy/features/request_flyout.test.ts ``` I tested that the component works in the browser, so the issue is in the test. I think that because of some internal React@18 changes the order in which the validation timeout inside our form lib is called conflcts with fake timers (the timeout just stucks). So instead of trying to add additional `jest.advanceTimersByTime(0);` in some places I decided to simplify and just use the real timeouts that works well for both react@17 an react@18
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@elastic/charts](https://togithub.com/elastic/elastic-charts) | dependencies | major | [`68.1.0` -> `69.0.0`](https://renovatebot.com/diffs/npm/@elastic%2fcharts/68.1.0/69.0.0) | --- ### Release Notes <details> <summary>elastic/elastic-charts (@&elastic#8203;elastic/charts)</summary> ### [`v69.0.0`](https://togithub.com/elastic/elastic-charts/blob/HEAD/CHANGELOG.md#6900-2025-01-28) [Compare Source](https://togithub.com/elastic/elastic-charts/compare/v68.1.0...v69.0.0) ##### Bug Fixes - **deps:** update dependency [@&elastic#8203;elastic/eui](https://togithub.com/elastic/eui) to v99 ([#&elastic#8203;2567](https://togithub.com/elastic/elastic-charts/issues/2567)) ([f397987](https://togithub.com/elastic/elastic-charts/commit/f3979877ae3ec86a36ab494c7601fcc559a000a0)) - **style:** align xy axis style to borealis ([#&elastic#8203;2584](https://togithub.com/elastic/elastic-charts/issues/2584)) ([9486374](https://togithub.com/elastic/elastic-charts/commit/9486374376c676550d185be008cecb9804a60bb9)) ##### Styles - **theme:** cleanup remaining theme changes ([#&elastic#8203;2602](https://togithub.com/elastic/elastic-charts/issues/2602)) ([beb4cf1](https://togithub.com/elastic/elastic-charts/commit/beb4cf108abbd6451bd252b5a33d87cae1d6aaef)), closes [#&elastic#8203;2601](https://togithub.com/elastic/elastic-charts/issues/2601) ##### BREAKING CHANGES - **theme:** the light and dark themes follow the EUI Borealis theme. </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjUuMSIsInVwZGF0ZWRJblZlciI6IjM3LjQyNS4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJUZWFtOlZpc3VhbGl6YXRpb25zIiwiYmFja3BvcnQ6cHJldi1taW5vciIsInJlbGVhc2Vfbm90ZTpza2lwIl19--> --------- Co-authored-by: elastic-renovate-prod[bot] <174716857+elastic-renovate-prod[bot]@users.noreply.github.com> Co-authored-by: Marco Vettorello <marco.vettorello@elastic.co> Co-authored-by: Nick Partridge <nicholas.partridge@elastic.co>
## Summary This PR introduces edit functionality for inference endpoints in the inference management UI. To support this, the following changes were made: - Refactored the `kbn-inference-endpoint-ui-common` package to include support for edit mode. - Moved the add inference endpoint functionality into the common plugin. - Updated each plugin to handle opening and closing the flyout, as well as providing a method for their specific task. - Refactored the way actions are defined in the inference management UI. https://github.com/user-attachments/assets/14d69f18-dc6e-4521-89fd-9c21e9b2443c ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [X] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [X] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [X] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
## Summary Enabling Inference API in serverless. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
## Summary Properly identify `rainbow-sprinkles` underlying model to apply the corresponding request transformation when used by the inference APIs. In practice, that means applying the array schema fix we were already using for bedrock. --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
…TCH operators (elastic#205565) Closes elastic#188978 Closes elastic#199092 This PR addresses elastic#199092 and adds automated script to sync operators and adds support for MATCH and its equivalent `:` match operator. https://github.com/user-attachments/assets/8f78345d-f1a0-4be4-8eba-2aae35225842 https://github.com/user-attachments/assets/eb9e63e3-0086-45a5-b782-199225895afc ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ... --------- Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
## Summary Added support for human readable `name` attribute for saved objects audit. - Updated the saved object type/registration with `nameAttribute` option - Updated the Saved Objects Security Extension to support passing object names to the audit functions - Updated the audit logger with a configuration option to opt out of including saved object names (the SOR and SSC should be aware of this to avoid operations when they are not necessary) - Updated Saved Object Repository functions - [x] `bulkCreate` - [x] `bulkGet` - [x] `bulkResolve` - [x] `bulkUpdate` - [x] `collectMultiNamespaceReferences` - [x] `get` - [x] `updateObjectsSpaces` - [x] `bulkDelete` - [x] `delete` - [x] `removeReferencesTo` - [x] Updated Secure Spaces Client functions - [x] `auditObjectsForSpaceDeletion` Functions that were not updated: - `authorizeFind` - now we log audit before the actual find with only types. Find is complex one, that can return a lot of saved objects. The benefit of adding a separate audit event vs potential performance cost can be considered negligible. https://github.com/elastic/kibana/blob/2f6b9f67d8351a5688e9c3753a4a7234e466dc6a/src/core/packages/saved-objects/api-server-internal/src/lib/apis/find.ts#L166 - `deleteByNamespace` - doesn't have an audit log itself, however is used only along with the `delete` which adds audit log with SO name https://github.com/elastic/kibana/blob/2f6b9f67d8351a5688e9c3753a4a7234e466dc6a/x-pack/platform/plugins/shared/spaces/server/spaces_client/spaces_client.ts#L223-L225 - `checkConflicts` - audit was intensionally bypassed https://github.com/elastic/kibana/blob/2f6b9f67d8351a5688e9c3753a4a7234e466dc6a/x-pack/platform/plugins/shared/security/server/saved_objects/saved_objects_security_extension.ts#L945-L948 - `disableLegacyUrlAliases` - function calls `bulkUpdate` in the end (which adds audit log with SO name already). Adding name to the `disableLegacyUrlAliases` audit log, will result in double saved objects get operation which is not feasible. https://github.com/elastic/kibana/blob/2f6b9f67d8351a5688e9c3753a4a7234e466dc6a/x-pack/platform/plugins/shared/spaces/server/spaces_client/spaces_client.ts#L228-L234 ## How to test Best way to test it is from the `Manage Saved Objects` page with audit enabled. - Import some test data set from the main page. - Go to the `Manage Saved Objects`: - Update single SO - Delete singe SO - Bulk update SOs - Bulk delete SOs - Import/export SOs ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) ### Release note Added support for human readable name attribute for saved objects audit events. __Closes: https://github.com/elastic/kibana/issues/200538__ --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Fixes elastic#204381 ## Summary The test that verifies tab changes in Console was failing because it was verifying the presence of the tab content before it was fully loaded. ### Checklist - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
… EuiTheme (elastic#207753) Closes elastic#207363 ### What was done Changed components from styled components to `@emotion` to use EuiTheme Just changed the components that might cause error in APM, and left the rest, as some of these components will be deprecated and are not a potential cause of errors currently
Automated by https://buildkite.com/elastic/package-storage-infra-kibana-discover-release-branches/builds/2126 Co-authored-by: elasticmachine <elasticmachine@elastic.co>
## Summary New test has been added for alerting in scope of this [PR](https://github.com/elastic/kibana/pull/201508/files#diff-9d14ca1fb9743d33cb159a3b6e9c40161e3aaed85192082b09254964bf9101acR218). We intentionally need to skip this test for FIPS due to [FIPS overrides](https://github.com/elastic/kibana/blob/542a56b4829643d05c47bcc47485dd9baaacea32/packages/kbn-test/src/functional_tests/lib/fips_overrides.ts). Added `skipFIPS` tag ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
In step 2 I added where exactly notifications.connectors.default is set in configuration. It did not explicitly say that it should be set in kibana.yml, also added configuration example. A reminder to set default connector should probably need to be added to this page as well: https://www.elastic.co/guide/en/kibana/current/pre-configured-connectors.html ## Summary Summarize your PR. If it involves visual changes include a screenshot or gif. ### Checklist Delete any items that are not applicable to this PR. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### Risk Matrix Delete this section if it is not applicable to this PR. Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release. When forming the risk matrix, consider some of the following examples and how they may potentially impact the change: | Risk | Probability | Severity | Mitigation/Notes | |---------------------------|-------------|----------|-------------------------| | Multiple Spaces—unexpected behavior in non-default Kibana Space. | Low | High | Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces. | | Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. | High | Low | Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure. | | Code should gracefully handle cases when feature X or plugin Y are disabled. | Medium | High | Unit tests will verify that any feature flag or plugin combination still results in our service operational. | | [See more potential risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) | ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) Co-authored-by: florent-leborgne <florent.leborgne@elastic.co>
…8672) ## Summary Closes elastic#208290 Rollback `includeComments` in `resolve` case endpoint to fix the alerts tab in cases detail page. I'll create a new issue to use an alternative approach to get the data needed by the alerts tab. #### To do (might be shipped after FF): - [ ] Test the alert tab shows the right amount of alerts in header - [ ] Test the alert tab shows the alerts in content table ### QA - Create alerts in security - Add an alert to a case - Check: <details> <summary>that number of alerts isn't 0 and the alert commet in activity list exist</summary> <img width="1022" alt="Screenshot 2025-01-29 at 06 53 10" src="https://github.com/user-attachments/assets/0a95ee88-4c00-4a53-88a7-563560351a73" /> </details> <details> <summary>Table with alert is rendered when in alerts tab</summary> <img width="559" alt="Screenshot 2025-01-29 at 06 57 27" src="https://github.com/user-attachments/assets/95242c57-6eac-42e5-9801-534c8d7d6577" /> </details>
## Summary The `JOIN` command grammar has been changed to accept `ESQLSource` as the first command argument instead of `ESQLIdentifier`. This PR addresses that change throughout the "ast" and "validation" packages. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
## Summary Closes elastic#208519 To verify: - Add Network Packet Capture integration - verify that there is no UI error when adding the package policy <img width="1418" alt="image" src="https://github.com/user-attachments/assets/2806f717-995a-4c7a-9532-08be30f0cd10" /> ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
## Summary Adding a note that for logs, in case the name of the filebeat index was changed, it's needed to adjust `monitoring.ui.logs.index` so that the logs stats can be retrieved as well
This PR enables the feature flag for workflow insights, activates defend insights within the Assistant scope, and aligns the tests accordingly. The added privileges originate from [this PR](elastic#205088).
…re to the advanced settings (elastic#208614) ## Summary During 8.17 development cycle, we introduced a new feature behind an experimental flag. Now, in 8.18/9.0 a user could toggle the feature through the advanced settings. This will allow users on serverless to use this feature. This change does not introduce a breaking change.  ### How to test 1. Toggle the feature flags 2. Load mock data ```bash node scripts/es_archiver load x-pack/test/cloud_security_posture_functional/es_archives/logs_gcp_audit \ --es-url http://elastic:changeme@localhost:9200 \ --kibana-url http://elastic:changeme@localhost:5601 node scripts/es_archiver load x-pack/test/cloud_security_posture_functional/es_archives/security_alerts \ --es-url http://elastic:changeme@localhost:9200 \ --kibana-url http://elastic:changeme@localhost:5601 ``` 3. Go to the alerts page 4. Change the query time range to show alerts from the 13th of October 2024 (**IMPORTANT**) 5. Open the alerts flyout 6. Scroll to see the graph visualization : D ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Updating the documentation so that the jackson-databind dependency matches the one used by the java client.
…ration (elastic#208257) ## Summary Closes elastic#201281 Closes elastic#200653 --------- Co-authored-by: wajihaparvez <wajiha.parvez@elastic.co>
That way we can internally link to this beautiful section using `<<angle-brackets-and-stuff>>` --------- Co-authored-by: florent-leborgne <florent.leborgne@elastic.co>
## Summary This PR aims at relocating some of the Kibana modules (plugins and packages) into a new folder structure, according to the _Sustainable Kibana Architecture_ initiative. > [!IMPORTANT] > * We kindly ask you to: > * Manually fix the errors in the error section below (if there are any). > * Search for the `packages[\/\\]` and `plugins[\/\\]` patterns in the source code (Babel and Eslint config files), and update them appropriately. > * Manually review `.buildkite/scripts/pipelines/pull_request/pipeline.ts` to ensure that any CI pipeline customizations continue to be correctly applied after the changed path names > * Review all of the updated files, specially the `.ts` and `.js` files listed in the sections below, as some of them contain relative paths that have been updated. > * Think of potential impact of the move, including tooling and configuration files that can be pointing to the relocated modules. E.g.: > * customised eslint rules > * docs pointing to source code > [!NOTE] > * This PR has been auto-generated. > * Any manual contributions will be lost if the 'relocate' script is re-run. > * Try to obtain the missing reviews / approvals before applying manual fixes, and/or keep your changes in a .patch / git stash. > * Please use [#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E) Slack channel for feedback. Are you trying to rebase this PR to solve merge conflicts? Please follow the steps describe [here](https://elastic.slack.com/archives/C07TCKTA22E/p1734019532879269?thread_ts=1734019339.935419&cid=C07TCKTA22E). #### 55 packages(s) are going to be relocated: | Id | Target folder | | -- | ------------- | | `@kbn/core-analytics-browser-mocks` | `src/core/packages/analytics/browser-mocks` | | `@kbn/core-analytics-server-mocks` | `src/core/packages/analytics/server-mocks` | | `@kbn/core-application-browser-mocks` | `src/core/packages/application/browser-mocks` | | `@kbn/core-apps-browser-mocks` | `src/core/packages/apps/browser-mocks` | | `@kbn/core-base-browser-mocks` | `src/core/packages/base/browser-mocks` | | `@kbn/core-base-server-mocks` | `src/core/packages/base/server-mocks` | | `@kbn/core-capabilities-browser-mocks` | `src/core/packages/capabilities/browser-mocks` | | `@kbn/core-capabilities-server-mocks` | `src/core/packages/capabilities/server-mocks` | | `@kbn/core-chrome-browser-mocks` | `src/core/packages/chrome/browser-mocks` | | `@kbn/core-deprecations-browser-mocks` | `src/core/packages/deprecations/browser-mocks` | | `@kbn/core-deprecations-server-mocks` | `src/core/packages/deprecations/server-mocks` | | `@kbn/core-doc-links-browser-mocks` | `src/core/packages/doc-links/browser-mocks` | | `@kbn/core-doc-links-server-mocks` | `src/core/packages/doc-links/server-mocks` | | `@kbn/core-elasticsearch-client-server-mocks` | `src/core/packages/elasticsearch/client-server-mocks` | | `@kbn/core-elasticsearch-server-mocks` | `src/core/packages/elasticsearch/server-mocks` | | `@kbn/core-environment-server-mocks` | `src/core/packages/environment/server-mocks` | | `@kbn/core-execution-context-browser-mocks` | `src/core/packages/execution-context/browser-mocks` | | `@kbn/core-execution-context-server-mocks` | `src/core/packages/execution-context/server-mocks` | | `@kbn/core-fatal-errors-browser-mocks` | `src/core/packages/fatal-errors/browser-mocks` | | `@kbn/core-http-browser-mocks` | `src/core/packages/http/browser-mocks` | | `@kbn/core-http-context-server-mocks` | `src/core/packages/http/context-server-mocks` | | `@kbn/core-http-resources-server-mocks` | `src/core/packages/http/resources-server-mocks` | | `@kbn/core-http-router-server-mocks` | `src/core/packages/http/router-server-mocks` | | `@kbn/core-http-server-mocks` | `src/core/packages/http/server-mocks` | | `@kbn/core-i18n-browser-mocks` | `src/core/packages/i18n/browser-mocks` | | `@kbn/core-i18n-server-mocks` | `src/core/packages/i18n/server-mocks` | | `@kbn/core-injected-metadata-browser-mocks` | `src/core/packages/injected-metadata/browser-mocks` | | `@kbn/core-integrations-browser-mocks` | `src/core/packages/integrations/browser-mocks` | | `@kbn/core-lifecycle-browser-mocks` | `src/core/packages/lifecycle/browser-mocks` | | `@kbn/core-lifecycle-server-mocks` | `src/core/packages/lifecycle/server-mocks` | | `@kbn/core-logging-browser-mocks` | `src/core/packages/logging/browser-mocks` | | `@kbn/core-logging-server-mocks` | `src/core/packages/logging/server-mocks` | | `@kbn/core-metrics-collectors-server-mocks` | `src/core/packages/metrics/collectors-server-mocks` | | `@kbn/core-metrics-server-mocks` | `src/core/packages/metrics/server-mocks` | | `@kbn/core-node-server-mocks` | `src/core/packages/node/server-mocks` | | `@kbn/core-notifications-browser-mocks` | `src/core/packages/notifications/browser-mocks` | | `@kbn/core-overlays-browser-mocks` | `src/core/packages/overlays/browser-mocks` | | `@kbn/core-plugins-browser-mocks` | `src/core/packages/plugins/browser-mocks` | | `@kbn/core-plugins-server-mocks` | `src/core/packages/plugins/server-mocks` | | `@kbn/core-preboot-server-mocks` | `src/core/packages/preboot/server-mocks` | | `@kbn/core-rendering-browser-mocks` | `src/core/packages/rendering/browser-mocks` | | `@kbn/core-rendering-server-mocks` | `src/core/packages/rendering/server-mocks` | | `@kbn/core-saved-objects-api-server-mocks` | `src/core/packages/saved-objects/api-server-mocks` | | `@kbn/core-saved-objects-base-server-mocks` | `src/core/packages/saved-objects/base-server-mocks` | | `@kbn/core-saved-objects-browser-mocks` | `src/core/packages/saved-objects/browser-mocks` | | `@kbn/core-saved-objects-import-export-server-mocks` | `src/core/packages/saved-objects/import-export-server-mocks` | | `@kbn/core-saved-objects-migration-server-mocks` | `src/core/packages/saved-objects/migration-server-mocks` | | `@kbn/core-saved-objects-server-mocks` | `src/core/packages/saved-objects/server-mocks` | | `@kbn/core-status-server-mocks` | `src/core/packages/status/server-mocks` | | `@kbn/core-test-helpers-kbn-server` | `src/dev/packages/core-test-helpers-kbn-server` | | `@kbn/core-test-helpers-model-versions` | `src/dev/packages/core-test-helpers-model-versions` | | `@kbn/core-theme-browser-mocks` | `src/core/packages/theme/browser-mocks` | | `@kbn/core-ui-settings-browser-mocks` | `src/core/packages/ui-settings/browser-mocks` | | `@kbn/core-ui-settings-server-mocks` | `src/core/packages/ui-settings/server-mocks` | | `@kbn/core-usage-data-server-mocks` | `src/core/packages/usage-data/server-mocks` | <details > <summary>Updated references</summary> ``` ./.github/codeql/codeql-config.yml ./package.json ./packages/kbn-ts-projects/config-paths.json ./src/core/packages/analytics/browser-mocks/jest.config.js ./src/core/packages/analytics/server-mocks/jest.config.js ./src/core/packages/application/browser-mocks/jest.config.js ./src/core/packages/apps/browser-mocks/jest.config.js ./src/core/packages/base/browser-mocks/jest.config.js ./src/core/packages/base/server-mocks/jest.config.js ./src/core/packages/capabilities/browser-mocks/jest.config.js ./src/core/packages/capabilities/server-mocks/jest.config.js ./src/core/packages/chrome/browser-mocks/jest.config.js ./src/core/packages/deprecations/browser-mocks/jest.config.js ./src/core/packages/deprecations/server-mocks/jest.config.js ./src/core/packages/doc-links/browser-mocks/jest.config.js ./src/core/packages/doc-links/server-mocks/jest.config.js ./src/core/packages/elasticsearch/client-server-mocks/jest.config.js ./src/core/packages/elasticsearch/server-mocks/jest.config.js ./src/core/packages/environment/server-mocks/jest.config.js ./src/core/packages/execution-context/browser-mocks/jest.config.js ./src/core/packages/execution-context/server-mocks/jest.config.js ./src/core/packages/fatal-errors/browser-mocks/jest.config.js ./src/core/packages/http/browser-mocks/jest.config.js ./src/core/packages/http/context-server-mocks/jest.config.js ./src/core/packages/http/resources-server-mocks/jest.config.js ./src/core/packages/http/router-server-mocks/jest.config.js ./src/core/packages/http/server-mocks/jest.config.js ./src/core/packages/i18n/browser-mocks/jest.config.js ./src/core/packages/i18n/server-mocks/jest.config.js ./src/core/packages/injected-metadata/browser-mocks/jest.config.js ./src/core/packages/integrations/browser-mocks/jest.config.js ./src/core/packages/lifecycle/browser-mocks/jest.config.js ./src/core/packages/lifecycle/server-mocks/jest.config.js ./src/core/packages/logging/browser-mocks/jest.config.js ./src/core/packages/logging/server-mocks/jest.config.js ./src/core/packages/metrics/collectors-server-mocks/jest.config.js ./src/core/packages/metrics/server-mocks/jest.config.js ./src/core/packages/node/server-mocks/jest.config.js ./src/core/packages/notifications/browser-mocks/jest.config.js ./src/core/packages/overlays/browser-mocks/jest.config.js ./src/core/packages/plugins/browser-mocks/jest.config.js ./src/core/packages/plugins/server-mocks/jest.config.js ./src/core/packages/preboot/server-mocks/jest.config.js ./src/core/packages/rendering/browser-mocks/jest.config.js ./src/core/packages/rendering/server-mocks/jest.config.js ./src/core/packages/saved-objects/api-server-mocks/jest.config.js ./src/core/packages/saved-objects/base-server-mocks/jest.config.js ./src/core/packages/saved-objects/browser-mocks/jest.config.js ./src/core/packages/saved-objects/import-export-server-mocks/jest.config.js ./src/core/packages/saved-objects/migration-server-mocks/jest.config.js ./src/core/packages/saved-objects/server-mocks/jest.config.js ./src/core/packages/status/server-mocks/jest.config.js ./src/core/packages/theme/browser-mocks/jest.config.js ./src/core/packages/ui-settings/browser-mocks/jest.config.js ./src/core/packages/ui-settings/server-mocks/jest.config.js ./src/core/packages/usage-data/server-mocks/jest.config.js ./src/core/system/tsconfig.type_check.json ./src/dev/packages/core-test-helpers-kbn-server/jest.config.js ./src/dev/packages/core-test-helpers-model-versions/jest.config.js ./src/dev/tsconfig.type_check.json ./src/platform/packages/private/kbn-repo-packages/package-map.json ./src/platform/plugins/private/interactive_setup/tsconfig.type_check.json ./src/platform/plugins/shared/console/tsconfig.type_check.json ./src/plugins/kibana_usage_collection/tsconfig.type_check.json ./src/plugins/saved_objects_management/tsconfig.type_check.json ./src/plugins/telemetry/tsconfig.type_check.json ./src/plugins/usage_collection/tsconfig.type_check.json ./tsconfig.base.json ./tsconfig.base.type_check.json ./tsconfig.refs.json ./x-pack/platform/plugins/private/index_lifecycle_management/tsconfig.type_check.json ./x-pack/platform/plugins/private/remote_clusters/tsconfig.type_check.json ./x-pack/platform/plugins/private/snapshot_restore/tsconfig.type_check.json ./x-pack/platform/plugins/private/watcher/tsconfig.type_check.json ./x-pack/platform/plugins/shared/encrypted_saved_objects/tsconfig.type_check.json ./x-pack/platform/plugins/shared/fleet/tsconfig.type_check.json ./x-pack/platform/plugins/shared/security/tsconfig.type_check.json ./x-pack/platform/plugins/shared/spaces/tsconfig.type_check.json ./x-pack/plugins/actions/tsconfig.type_check.json ./x-pack/plugins/aiops/tsconfig.type_check.json ./x-pack/plugins/alerting/tsconfig.type_check.json ./x-pack/plugins/cases/tsconfig.type_check.json ./x-pack/plugins/enterprise_search/tsconfig.type_check.json ./x-pack/plugins/integration_assistant/tsconfig.type_check.json ./x-pack/plugins/ml/tsconfig.type_check.json ./x-pack/plugins/observability_solution/apm/tsconfig.type_check.json ./x-pack/plugins/observability_solution/apm_data_access/tsconfig.type_check.json ./x-pack/plugins/observability_solution/entity_manager/tsconfig.type_check.json ./x-pack/plugins/observability_solution/exploratory_view/tsconfig.type_check.json ./x-pack/plugins/observability_solution/observability/tsconfig.type_check.json ./x-pack/plugins/observability_solution/slo/tsconfig.type_check.json ./x-pack/plugins/observability_solution/synthetics/tsconfig.type_check.json ./x-pack/plugins/observability_solution/uptime/tsconfig.type_check.json ./x-pack/plugins/rule_registry/tsconfig.type_check.json ./x-pack/plugins/search_playground/tsconfig.type_check.json ./x-pack/plugins/serverless_search/tsconfig.type_check.json ./x-pack/plugins/stack_alerts/tsconfig.type_check.json ./x-pack/plugins/stack_connectors/tsconfig.type_check.json ./x-pack/plugins/task_manager/tsconfig.type_check.json ./x-pack/plugins/transform/tsconfig.type_check.json ./x-pack/solutions/observability/plugins/dataset_quality/tsconfig.type_check.json ./x-pack/solutions/security/packages/security-solution/ecs_data_quality_dashboard/tsconfig.type_check.json ./x-pack/solutions/security/plugins/ecs_data_quality_dashboard/tsconfig.type_check.json ./yarn.lock .github/CODEOWNERS ``` </details><details > <summary>Updated relative paths</summary> ``` src/core/packages/analytics/browser-mocks/jest.config.js:12 src/core/packages/analytics/browser-mocks/tsconfig.json:2 src/core/packages/analytics/server-mocks/jest.config.js:12 src/core/packages/analytics/server-mocks/tsconfig.json:2 src/core/packages/application/browser-mocks/jest.config.js:12 src/core/packages/application/browser-mocks/tsconfig.json:2 src/core/packages/apps/browser-mocks/jest.config.js:12 src/core/packages/apps/browser-mocks/tsconfig.json:2 src/core/packages/base/browser-mocks/jest.config.js:12 src/core/packages/base/browser-mocks/tsconfig.json:2 src/core/packages/base/server-mocks/jest.config.js:12 src/core/packages/base/server-mocks/tsconfig.json:2 src/core/packages/capabilities/browser-mocks/jest.config.js:12 src/core/packages/capabilities/browser-mocks/tsconfig.json:2 src/core/packages/capabilities/server-mocks/jest.config.js:12 src/core/packages/capabilities/server-mocks/tsconfig.json:2 src/core/packages/chrome/browser-mocks/jest.config.js:12 src/core/packages/chrome/browser-mocks/tsconfig.json:2 src/core/packages/deprecations/browser-mocks/jest.config.js:12 src/core/packages/deprecations/browser-mocks/tsconfig.json:2 src/core/packages/deprecations/server-mocks/jest.config.js:12 src/core/packages/deprecations/server-mocks/tsconfig.json:2 src/core/packages/doc-links/browser-mocks/jest.config.js:12 src/core/packages/doc-links/browser-mocks/tsconfig.json:2 src/core/packages/doc-links/server-mocks/jest.config.js:12 src/core/packages/doc-links/server-mocks/tsconfig.json:2 src/core/packages/elasticsearch/client-server-mocks/jest.config.js:12 src/core/packages/elasticsearch/client-server-mocks/tsconfig.json:2 src/core/packages/elasticsearch/server-mocks/jest.config.js:12 src/core/packages/elasticsearch/server-mocks/tsconfig.json:2 src/core/packages/environment/server-mocks/jest.config.js:12 src/core/packages/environment/server-mocks/tsconfig.json:2 src/core/packages/execution-context/browser-mocks/jest.config.js:12 src/core/packages/execution-context/browser-mocks/tsconfig.json:2 src/core/packages/execution-context/server-mocks/jest.config.js:12 src/core/packages/execution-context/server-mocks/tsconfig.json:2 src/core/packages/fatal-errors/browser-mocks/jest.config.js:12 src/core/packages/fatal-errors/browser-mocks/tsconfig.json:2 src/core/packages/http/browser-mocks/jest.config.js:12 src/core/packages/http/browser-mocks/tsconfig.json:2 src/core/packages/http/context-server-mocks/jest.config.js:12 src/core/packages/http/context-server-mocks/tsconfig.json:2 src/core/packages/http/resources-server-mocks/jest.config.js:12 src/core/packages/http/resources-server-mocks/tsconfig.json:2 src/core/packages/http/router-server-mocks/jest.config.js:12 src/core/packages/http/router-server-mocks/tsconfig.json:2 src/core/packages/http/server-mocks/jest.config.js:12 src/core/packages/http/server-mocks/tsconfig.json:2 src/core/packages/i18n/browser-mocks/jest.config.js:12 src/core/packages/i18n/browser-mocks/tsconfig.json:2 src/core/packages/i18n/server-mocks/jest.config.js:12 src/core/packages/i18n/server-mocks/tsconfig.json:2 src/core/packages/injected-metadata/browser-mocks/jest.config.js:12 src/core/packages/injected-metadata/browser-mocks/tsconfig.json:2 src/core/packages/integrations/browser-mocks/jest.config.js:12 src/core/packages/integrations/browser-mocks/tsconfig.json:2 src/core/packages/lifecycle/browser-mocks/jest.config.js:12 src/core/packages/lifecycle/browser-mocks/tsconfig.json:2 src/core/packages/lifecycle/server-mocks/jest.config.js:12 src/core/packages/lifecycle/server-mocks/tsconfig.json:2 src/core/packages/logging/browser-mocks/jest.config.js:12 src/core/packages/logging/browser-mocks/tsconfig.json:2 src/core/packages/logging/server-mocks/jest.config.js:12 src/core/packages/logging/server-mocks/tsconfig.json:2 src/core/packages/metrics/collectors-server-mocks/jest.config.js:12 src/core/packages/metrics/collectors-server-mocks/tsconfig.json:2 src/core/packages/metrics/server-mocks/jest.config.js:12 src/core/packages/metrics/server-mocks/tsconfig.json:2 src/core/packages/node/server-mocks/jest.config.js:12 src/core/packages/node/server-mocks/tsconfig.json:2 src/core/packages/notifications/browser-mocks/jest.config.js:12 src/core/packages/notifications/browser-mocks/tsconfig.json:2 src/core/packages/overlays/browser-mocks/jest.config.js:12 src/core/packages/overlays/browser-mocks/tsconfig.json:2 src/core/packages/plugins/browser-mocks/jest.config.js:12 src/core/packages/plugins/browser-mocks/tsconfig.json:2 src/core/packages/plugins/server-mocks/jest.config.js:12 src/core/packages/plugins/server-mocks/tsconfig.json:2 src/core/packages/preboot/server-mocks/jest.config.js:12 src/core/packages/preboot/server-mocks/tsconfig.json:2 src/core/packages/rendering/browser-mocks/jest.config.js:12 src/core/packages/rendering/browser-mocks/tsconfig.json:2 src/core/packages/rendering/server-mocks/jest.config.js:12 src/core/packages/rendering/server-mocks/tsconfig.json:2 src/core/packages/saved-objects/api-server-mocks/jest.config.js:12 src/core/packages/saved-objects/api-server-mocks/tsconfig.json:2 src/core/packages/saved-objects/base-server-mocks/jest.config.js:12 src/core/packages/saved-objects/base-server-mocks/tsconfig.json:2 src/core/packages/saved-objects/browser-mocks/jest.config.js:12 src/core/packages/saved-objects/browser-mocks/tsconfig.json:2 src/core/packages/saved-objects/import-export-server-mocks/jest.config.js:12 src/core/packages/saved-objects/import-export-server-mocks/tsconfig.json:2 src/core/packages/saved-objects/migration-server-mocks/jest.config.js:12 src/core/packages/saved-objects/migration-server-mocks/tsconfig.json:2 src/core/packages/saved-objects/server-mocks/jest.config.js:12 src/core/packages/saved-objects/server-mocks/tsconfig.json:2 src/core/packages/status/server-mocks/jest.config.js:12 src/core/packages/status/server-mocks/tsconfig.json:2 src/core/packages/theme/browser-mocks/jest.config.js:12 src/core/packages/theme/browser-mocks/tsconfig.json:2 src/core/packages/ui-settings/browser-mocks/jest.config.js:12 src/core/packages/ui-settings/browser-mocks/tsconfig.json:2 src/core/packages/ui-settings/server-mocks/jest.config.js:12 src/core/packages/ui-settings/server-mocks/tsconfig.json:2 src/core/packages/usage-data/server-mocks/jest.config.js:12 src/core/packages/usage-data/server-mocks/tsconfig.json:2 src/dev/packages/core-test-helpers-kbn-server/jest.config.js:12 src/dev/packages/core-test-helpers-kbn-server/tsconfig.json:2 src/dev/packages/core-test-helpers-model-versions/jest.config.js:12 src/dev/packages/core-test-helpers-model-versions/tsconfig.json:2 ``` </details> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Alejandro Fernández Haro <afharo@gmail.com>
Closes elastic#207005 ## Summary This PR tries to fix the service map tests: - Fists fix is waiting for the request to address the timeout issue - ~The second fix changes the snapshot image because of the borealis change the fonts/colors are now different:~ I tried many ways to fix the tests with the screenshots but they have different sizes on every run (headless or not) and in the CI they are also different. So the Borealis there was just a single change there but the flakiness comes from the screenshots being inconsistent (I will investigate that further separately and will leave them skipped in the PR
…ad flyout (elastic#208595) ## Summary Disclaimer added when uploading rules: _Note: To avoid exceeding your LLM API rate limit when translating a large number of queries, consider exporting rules in batches, for example by adding `| head` to the query above._ ### Screenshot 
…lastic#208398) ## Summary This PR adds quick-checks regarding pipeline resource definitions. - Adds validation/correction for `locations.yml` - Adds validation for definitions (through `docker.elastic.co/ci-agent-images/pipelib rre validate`). - Also fixes a missing pipeline entry in `locations.yml` Example for when a YML error bounces on schema validation: https://buildkite.com/elastic/kibana-pull-request/builds/270652#0194a8d5-48df-4f1b-8ec7-1f076851d138 Example for auto-fixing missing location: elastic@b2170ac --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Updating limitation of dev tool which is not sending request with round robin ## Summary We believe Console always tries to connect to the 1st host in elasticsearch.hosts but if it's unavailable then it will try the next one, the code for this can be found [here](https://github.com/elastic/kibana/blob/0d613e58cf153c3ac7890b742f00b24fcc55a104/src/plugins/console/server/routes/api/console/proxy/create_handler.ts#L125). So in that case, as long as the node is still available, it will receive all the requests from Console. ### Checklist Delete any items that are not applicable to this PR. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials Co-authored-by: florent-leborgne <florent.leborgne@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Summarize your PR. If it involves visual changes include a screenshot or gif.
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:breaking
label should be applied in these situations.release_note:*
label is applied per the guidelinesIdentify risks
Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.
Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.