Upgrade npm dependencies and enble building with nodejs v12 #1855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated the npm dependencies fixing a lot of security warning from NPM.
Moreover, I added an install.sh script, which should be called instead of 'npm install' and pushes ttf2woff2 to version 3.0.0 in order to work arund this issue: sapegin/grunt-webfont#394
Please note, that it is strongly discouraged to commit npm-shrinkwrap.json files to repos, that's why I came up with a shell script to push a transitive dependency up to the point the original issue is fixed in grunt-webfont.