lint bump to v1.59.1 (#96)

Author: vladopajic

.github/workflows/lint.yml

@@ -14,6 +14,6 @@ jobs:
       - name: golangci-lint
         uses: golangci/golangci-lint-action@v6
         with:
-          version: v1.56.2
+          version: v1.59.1
       - name: go mod tidy check
         uses: katexochen/go-tidy-check@v2

.golangci.yml

@@ -15,6 +15,7 @@ linters:
     - dupl
     - durationcheck
     - dupword
+    - err113
     - errcheck
     - errchkjson
     - errname
@@ -33,12 +34,10 @@ linters:
     - gocritic
     - gocyclo
     - godox
-    - goerr113
     - gofmt
     - gofumpt
     - goheader
     - goimports
-    - gomnd
     - gomoddirectives
     - gomodguard
     - goprintffuncname
@@ -55,6 +54,7 @@ linters:
     - maintidx
     - mirror
     - misspell
+    - mnd
     - nakedret
     - nestif
     - nilerr
@@ -180,4 +180,4 @@ issues:
 
     - text: "do not define dynamic errors" ## dynamic errors are okay is this is simple tool
       linters:
-        - goerr113
+        - err113

Makefile

@@ -1,7 +1,7 @@
 GO ?= go
 GOBIN ?= $$($(GO) env GOPATH)/bin
 GOLANGCI_LINT ?= $(GOBIN)/golangci-lint
-GOLANGCI_LINT_VERSION ?= v1.56.2
+GOLANGCI_LINT_VERSION ?= v1.59.1
 
 # Code tidy
 .PHONY: tidy

main.go

@@ -81,7 +81,7 @@ func (args) Version() string {
 	return Name + " " + Version
 }
 
-//nolint:cyclop,maintidx,gomnd // relax
+//nolint:cyclop,maintidx,mnd // relax
 func (a *args) overrideConfig(cfg testcoverage.Config) (testcoverage.Config, error) {
 	if !isCIDefaultString(a.Profile) {
 		cfg.Profile = a.Profile

pkg/testcoverage/badge/generate.go

@@ -21,7 +21,7 @@ func Generate(coverage int) ([]byte, error) {
 }
 
 func Color(coverage int) string {
-	//nolint:gomnd // relax
+	//nolint:mnd // relax
 	switch {
 	case coverage >= 100:
 		return "#44cc11" // strong green

pkg/testcoverage/badge_test.go

@@ -30,7 +30,7 @@ func Test_GenerateAndSaveBadge_SaveToFile(t *testing.T) {
 
 	const coverage = 100
 
-	testFile := t.TempDir() + "/badge.svg" //nolint:goconst // relax
+	testFile := t.TempDir() + "/badge.svg"
 	buf := &bytes.Buffer{}
 	err := GenerateAndSaveBadge(buf, Config{
 		Badge: Badge{

pkg/testcoverage/badgestorer/file.go

@@ -10,7 +10,7 @@ func NewFile(filename string) Storer {
 	return &fileStorer{filename: filename}
 }
 
-//nolint:gosec,gomnd,wrapcheck // relax
+//nolint:gosec,mnd,wrapcheck // relax
 func (s *fileStorer) Store(data []byte) (bool, error) {
 	err := os.WriteFile(s.filename, data, 0o644)
 	if err != nil {

pkg/testcoverage/check_test.go

@@ -164,7 +164,7 @@ func TestCheckNoParallel(t *testing.T) {
 	})
 
 	t.Run("ok pass; with github output file", func(t *testing.T) {
-		testFile := t.TempDir() + "/ga.output" //nolint: goconst // relax
+		testFile := t.TempDir() + "/ga.output"
 		t.Setenv(GaOutputFileEnv, testFile)
 
 		buf := &bytes.Buffer{}

pkg/testcoverage/coverage/types.go

@@ -18,7 +18,7 @@ func (s Stats) CoveredPercentage() int {
 	return CoveredPercentage(s.Total, s.Covered)
 }
 
-//nolint:gomnd // relax
+//nolint:mnd // relax
 func CoveredPercentage(total, covered int64) int {
 	if total == 0 {
 		return 0

pkg/testcoverage/report.go

@@ -17,7 +17,7 @@ func ReportForHuman(w io.Writer, result AnalyzeResult) {
 	out := bufio.NewWriter(w)
 	defer out.Flush()
 
-	tabber := tabwriter.NewWriter(out, 1, 8, 2, '\t', 0) //nolint:gomnd // relax
+	tabber := tabwriter.NewWriter(out, 1, 8, 2, '\t', 0) //nolint:mnd // relax
 	defer tabber.Flush()
 
 	statusStr := func(passing bool) string {
@@ -124,7 +124,7 @@ func SetGithubActionOutput(result AnalyzeResult) error {
 }
 
 func openGitHubOutput(p string) (io.WriteCloser, error) {
-	//nolint:gomnd,wrapcheck // error is wrapped at level above
+	//nolint:mnd,wrapcheck // error is wrapped at level above
 	return os.OpenFile(p, os.O_APPEND|os.O_CREATE|os.O_WRONLY, 0o644)
 }