unit test improvement (#41)

Author: vladopajic

pkg/testcoverage/badge_test.go

@@ -35,21 +35,36 @@ func Test_GenerateAndSaveBadge_SaveToFile(t *testing.T) {
 		return
 	}
 
-	// should save badge to file
-	testFile := t.TempDir() + "/badge.svg"
+	t.Run("invalid file", func(t *testing.T) {
+		t.Parallel()
 
-	buf := &bytes.Buffer{}
-	err := GenerateAndSaveBadge(buf, Config{
-		Badge: Badge{
-			FileName: testFile,
-		},
-	}, 100)
-	assert.NoError(t, err)
-	assert.NotEmpty(t, buf.Bytes())
+		err := GenerateAndSaveBadge(nil, Config{
+			Badge: Badge{
+				FileName: t.TempDir(), // should not be able to write to directory
+			},
+		}, 100)
+		assert.Error(t, err)
+	})
 
-	contentBytes, err := os.ReadFile(testFile)
-	assert.NoError(t, err)
-	assert.NotEmpty(t, contentBytes)
+	t.Run("success", func(t *testing.T) {
+		t.Parallel()
+
+		// should save badge to file
+		testFile := t.TempDir() + "/badge.svg"
+
+		buf := &bytes.Buffer{}
+		err := GenerateAndSaveBadge(buf, Config{
+			Badge: Badge{
+				FileName: testFile,
+			},
+		}, 100)
+		assert.NoError(t, err)
+		assert.Contains(t, buf.String(), "Badge saved to file")
+
+		contentBytes, err := os.ReadFile(testFile)
+		assert.NoError(t, err)
+		assert.NotEmpty(t, contentBytes)
+	})
 }
 
 func Test_GenerateAndSaveBadge_SaveToCDN_NoAction(t *testing.T) {

pkg/testcoverage/utils.go

@@ -7,23 +7,14 @@ import (
 	"strings"
 )
 
-//nolint:gochecknoglobals // relax
-var separatorToReplace = regexp.QuoteMeta(string(filepath.Separator))
+const separatorToReplace = string(filepath.Separator)
 
 func normalizePathInRegex(path string) string {
 	if runtime.GOOS != "windows" {
 		return path
 	}
 
-	clean := regexp.MustCompile(`\\+/`).
-		ReplaceAllStringFunc(path, func(s string) string {
-			if strings.Count(s, "\\")%2 == 0 {
-				return s
-			}
-			return s[1:]
-		})
-
-	return strings.ReplaceAll(clean, "/", separatorToReplace)
+	return strings.ReplaceAll(path, "/", separatorToReplace)
 }
 
 type regRule struct {