Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cgen error for chaining a union field access, after a union pointer cast #22301

Closed
spytheman opened this issue Sep 24, 2024 · 2 comments · Fixed by #22309
Closed

cgen error for chaining a union field access, after a union pointer cast #22301

spytheman opened this issue Sep 24, 2024 · 2 comments · Fixed by #22309
Assignees
Labels
Bug This tag is applied to issues which reports bugs. Unit: cgen Bugs/feature requests, that are related to the default C generating backend. Unit: Compiler Bugs/feature requests, that are related to the V compiler in general.

Comments

@spytheman
Copy link
Member

spytheman commented Sep 24, 2024

V doctor:

V full version: V 0.4.7 4ee948f.e974460
OS: linux, Ubuntu 20.04.6 LTS
Processor: 2 cpus, 64bit, little endian, Intel(R) Core(TM) i3-3225 CPU @ 3.30GHz

getwd: /space/v/oo
vexe: /space/v/oo/v
vexe mtime: 2024-09-24 19:59:00

vroot: OK, value: /space/v/oo
VMODULES: OK, value: /home/delian/.vmodules
VTMP: OK, value: /tmp/v_1000

Git version: git version 2.46.0
Git vroot status: weekly.2024.39-6-ge974460b
.git/config present: true

CC version: cc (Ubuntu 10.5.0-1ubuntu1~20.04) 10.5.0
thirdparty/tcc status: thirdparty-linux-amd64 0134e9b9

What did you do?
./v -g -o vdbg cmd/v && ./vdbg a.v

union Convertor {
	su8_array_p [20]u8
	sint_array_p [5]int
}

a := [1,2,3,4,5]!
p := voidptr( unsafe { &Convertor( &a[0] ) } )
c := unsafe { &Convertor( p ).su8_array_p }
dump(a)
dump(p)
dump(c)

What did you expect to see?

a compiled program

What did you see instead?

================== C compilation error (from tcc): ==============
cc: /tmp/v_1000/a.01J8JSVFAZYGDSVMC5AX0B7X9T.tmp.c:13476: error: '{' expected (got ";")
=================================================================
(You can pass `-cg`, or `-show-c-output` as well, to print all the C error messages).

Note

You can use the 👍 reaction to increase the issue's priority for developers.

Please note that only the 👍 reaction to the issue itself counts as a vote.
Other reactions and those to comments will not be taken into account.

@spytheman spytheman added Bug This tag is applied to issues which reports bugs. Unit: Compiler Bugs/feature requests, that are related to the V compiler in general. Unit: cgen Bugs/feature requests, that are related to the default C generating backend. labels Sep 24, 2024
@spytheman
Copy link
Member Author

spytheman commented Sep 24, 2024

Note: a very similar program, compiles and runs:

union Convertor {
    su8_array_p [20]u8
    sint_array_p [5]int
}

a := [1,2,3,4,5]!
p := voidptr( unsafe { &Convertor( &a[0] ) } )
c := unsafe { &Convertor( p ) }
dump(a)
dump(p)
dump(c)
dump(unsafe { c.su8_array_p } )

producing:

[a.v:9] a: [1, 2, 3, 4, 5]
[a.v:10] p: 0x7fffffffd74c
[a.v:11] c: &Convertor{
    su8_array_p: [1, 0, 0, 0, 2, 0, 0, 0, 3, 0, 0, 0, 4, 0, 0, 0, 5, 0, 0, 0]
    sint_array_p: [1, 2, 3, 4, 5]
}
[a.v:12] unsafe { c.su8_array_p }: [1, 0, 0, 0, 2, 0, 0, 0, 3, 0, 0, 0, 4, 0, 0, 0, 5, 0, 0, 0]

@spytheman
Copy link
Member Author

union Convertor {
    su8_array_p [20]u8
    sint_array_p [5]int
}

a := [1,2,3,4,5]!
p := voidptr( unsafe { &Convertor( &a[0] ) } )
dump(a)
dump(p)
dump(unsafe { &Convertor( p ).su8_array_p } )

this also compiles and runs fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This tag is applied to issues which reports bugs. Unit: cgen Bugs/feature requests, that are related to the default C generating backend. Unit: Compiler Bugs/feature requests, that are related to the V compiler in general.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants