-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
decoder2: decode bool and numbers #22550
Conversation
// string_buffer_to_generic_number converts a buffer of bytes (data) into a generic type T and | ||
// stores the result in the provided result pointer. | ||
// The function supports conversion to the following types: | ||
// - Signed integers: i8, i16, int, i64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May want to make this i8, i16, i32, i64
since int
is supposed to change in the future... it will be 32 bits on 32 bit systems, and 64 bits on 64 bit systems.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good find. I will change it in next PR to avoid rerun CI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heh. CI is less that halfway done.
feature example
benchmark