Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto.ecdsa: migrate core routines for signing (and verifying) #23705

Merged
merged 5 commits into from
Feb 17, 2025

Conversation

blackshirt
Copy link
Contributor

@blackshirt blackshirt commented Feb 13, 2025

This PR is the main part of the migration efforts to the crypto.ecdsa module to support for the high level unobsoleted API. The old OpenSSL 1.1.1. series has reached its End of Life (EOL). As such it will no longer receive publicly available security fixes, see eol-of-ossl.1.1.1 for more detail, so, maybe better to just upgrade your openssl to the 3.x series.

In this current PR, the main concerns was adding support to .sign() and .verify() routines to support the new api. Its done by using some changes to the internal detail of the current one, ie, in the form:

  • Adds support to use a new high level opaque into .sign() and .verify() methods.
  • Renames internal .sign_message into .sign_digest to reflect underlying its wrapped. Its sign the digest internally.
  • Adds some helpers to cooperate with the rest. Some helpers are just redundant with the old one, because we supporting two opaque here, but, its can be removed (cleaned) on later pr.
  • Adds some C required declarations.
  • Some bits of cleans up

Thats its. thanks

Copy link

Connected to Huly®: V_0.6-22124

@spytheman
Copy link
Member

(should be merged after #23706, which changes the runners to Ubuntu 24.04, which has OpenSSL 3)

@blackshirt
Copy link
Contributor Author

(should be merged after #23706, which changes the runners to Ubuntu 24.04, which has OpenSSL 3)

Okey ..i saw v2 related errors i cant reproduce.. is this related with the ci runners?

@JalonSolov
Copy link
Contributor

I only see crypto/ecdsa test failures in the last run.

@spytheman
Copy link
Member

(rebased over current master, which now runs the CI jobs on Ubuntu 22.04 and Ubuntu 24.04, which should have OpenSSL 3, instead of OpenSSL 1.1)

@spytheman spytheman merged commit 66e1d14 into vlang:master Feb 17, 2025
68 checks passed
@blackshirt
Copy link
Contributor Author

(rebased over current master, which now runs the CI jobs on Ubuntu 22.04 and Ubuntu 24.04, which should have OpenSSL 3, instead of OpenSSL 1.1)

Thanks, i think its good to move the new one start from here

@blackshirt blackshirt deleted the new-signer branch February 18, 2025 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants