native: cleanup assign, fix nested struct #23778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Connected to Huly®: V_0.6-22189 |
JalonSolov
approved these changes
Feb 20, 2025
spytheman
reviewed
Feb 21, 2025
spytheman
reviewed
Feb 21, 2025
spytheman
reviewed
Feb 21, 2025
spytheman
reviewed
Feb 21, 2025
|
Oh true, == is not implemented for floats. |
spytheman
reviewed
Feb 21, 2025
Comment on lines
+31
to
42
|
|
||
| a = 1.0 | ||
| mut b := &a | ||
| unsafe{*b += 2.5} | ||
| assert a == 3.5 | ||
| unsafe{*b -= 1.25} | ||
| assert a == 2.25 | ||
| unsafe{*b *= 6.0} | ||
| assert a == 13.5 | ||
| unsafe{*b /= 4.5} | ||
| assert a == 3.0 | ||
| } |
There was a problem hiding this comment.
however it can also serve as a check when the asserts and == work for f64, and the rest of the tests can cross check it, so imho it is good to merge as it is
There was a problem hiding this comment.
True, I'll change that for the next PR
There was a problem hiding this comment.
It will require to change all the tests in the file, as it is using asserts between floats for all checks.
There was a problem hiding this comment.
I may wait until assert between floats are fixed as some of the tests would be interesting to keep as such.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup the
assign_stmtfunction (and some functions called in it)Add file:line on some n_error calls for faster debugging
Fix nested struct expressions, ex:
foo.bar.adid not workAdd tests for fixed behavior and for more already supported behavior