Skip to content

Commit d3e2907

Browse files
committed
fix review suggestions
Signed-off-by: MengqingCao <cmq0113@163.com>
1 parent 95f5574 commit d3e2907

File tree

3 files changed

+3
-18
lines changed

3 files changed

+3
-18
lines changed

.github/workflows/vllm_ascend_test_pd.yaml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ defaults:
3232

3333
jobs:
3434
test:
35-
if: ${{ github.event.label.name == 'module:pd' }}
35+
if: github.event_name == 'schedule' || github.event.label.name == 'module:pd'
3636
strategy:
3737
matrix:
3838
vllm_verison: [v0.8.5.post1]
@@ -96,6 +96,5 @@ jobs:
9696
pip install -v -e .
9797
9898
- name: Run vllm-project/vllm-ascend PD Disaggregation test
99-
if: github.event_name == 'schedule' || github.event.label.name == 'module:pd'
10099
run: |
101100
pytest -sv tests/e2e/pd_disaggreate/test_pd_e2e.py

tests/e2e/pd_disaggreate/setup_pd.sh

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -17,15 +17,6 @@
1717
# This file is a part of the vllm-ascend project.
1818
#
1919

20-
21-
function cleanup_instances() {
22-
VLLM_PID=$(pgrep -f "vllm serve")
23-
_info "===> Try kill -2 ${VLLM_PID} to exit."
24-
kill -2 "$VLLM_PID"
25-
wait_for_exit "$VLLM_PID"
26-
}
27-
28-
2920
function run_prefill_instance() {
3021
local model_name=$1
3122
local tp_size=$2
@@ -140,7 +131,4 @@ function run_proxy_server() {
140131
# Start the proxy server
141132
echo "Starting proxy server with command: $PROXY_CMD"
142133
$PROXY_CMD &
143-
144-
# Wait for the proxy to start
145-
sleep 3
146134
}

tests/e2e/pd_disaggreate/test_pd_e2e.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
#!/bin/bash
2-
31
#
42
# Copyright (c) 2025 Huawei Technologies Co., Ltd. All Rights Reserved.
53
#
@@ -75,8 +73,8 @@ def start_and_test_pipeline():
7573
proc = subprocess.Popen(["bash", SCRIPT_PATH])
7674
try:
7775
print("Waiting for proxy port to be available...")
78-
wait_for_port(PROXY_PORT, 1200)
79-
wait_for_port(DECODE_PORT, 1200)
76+
wait_for_port(PROXY_PORT, 180)
77+
wait_for_port(DECODE_PORT, 180)
8078

8179
# request
8280
payload = {

0 commit comments

Comments
 (0)