Skip to content

[CI/UT][PD Disaggreate] Initialize PD Disaggreate UT #889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 29, 2025
Merged

[CI/UT][PD Disaggreate] Initialize PD Disaggreate UT #889

merged 3 commits into from
May 29, 2025

Conversation

MengqingCao
Copy link
Collaborator

Initialize PD Disaggreate UT

MengqingCao
MengqingCao commented May 17, 2025
View reviewed changes
@MengqingCao MengqingCao marked this pull request as ready for review May 20, 2025 03:10
MengqingCao
MengqingCao commented May 20, 2025
View reviewed changes
@MengqingCao MengqingCao added the pd-test enable pd test for PR label May 20, 2025
@MengqingCao MengqingCao added pd-test enable pd test for PR and removed pd-test enable pd test for PR module:tests labels May 22, 2025
@MengqingCao MengqingCao added pd-test enable pd test for PR and removed pd-test enable pd test for PR labels May 22, 2025
@MengqingCao MengqingCao added pd-test enable pd test for PR and removed pd-test enable pd test for PR labels May 23, 2025
@MengqingCao MengqingCao added pd-test enable pd test for PR and removed pd-test enable pd test for PR module:tests labels May 26, 2025
Yikun
Yikun approved these changes May 26, 2025
View reviewed changes
Copy link
Collaborator

@Yikun Yikun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except some nits

@MengqingCao MengqingCao force-pushed the pdci branch 2 times, most recently from c5c929d to d3e2907 Compare May 26, 2025 09:27
@MengqingCao MengqingCao removed the pd-test enable pd test for PR label May 26, 2025
@MengqingCao MengqingCao added pd-test enable pd test for PR and removed pd-test enable pd test for PR labels May 26, 2025
@MengqingCao
Copy link
Collaborator Author

@Yikun @wangxiyuan Thanks for your review, and all the comments have beed addressed, could you merge it now?

@MengqingCao
[CI/UT][PD Disaggreate] Initialize PD Disaggreate UT
90192fc 
Signed-off-by: MengqingCao <cmq0113@163.com>
@MengqingCao MengqingCao added pd-test enable pd test for PR ready-for-test start test by label for PR and removed pd-test enable pd test for PR labels May 28, 2025
@MengqingCao
fix kv port
3d23ca3 
Signed-off-by: MengqingCao <cmq0113@163.com>
@MengqingCao MengqingCao added ready-for-test start test by label for PR and removed ready-for-test start test by label for PR labels May 28, 2025
@MengqingCao
fix kv port
c53ebd9 
Signed-off-by: MengqingCao <cmq0113@163.com>
@MengqingCao MengqingCao added ready-for-test start test by label for PR and removed ready-for-test start test by label for PR labels May 28, 2025
@wangxiyuan wangxiyuan merged commit 6eddbd2 into vllm-project:main May 29, 2025
26 of 27 checks passed
@MengqingCao MengqingCao deleted the pdci branch May 30, 2025 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whx-sjtu whx-sjtu whx-sjtu left review comments

@Yikun Yikun Yikun approved these changes

@wangxiyuan wangxiyuan wangxiyuan approved these changes

Assignees
No one assigned
Labels
module:tests pd-test enable pd test for PR ready-for-test start test by label for PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MengqingCao @Yikun @wangxiyuan @whx-sjtu