Skip to content

Commit b4df698

Browse files
committed
🐛 fixup setuptools version for triton
Signed-off-by: Joe Runde <Joseph.Runde@ibm.com>
1 parent 837c196 commit b4df698

File tree

2 files changed

+1
-4
lines changed

2 files changed

+1
-4
lines changed

Dockerfile

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -180,10 +180,6 @@ FROM vllm-base AS test
180180
ADD . /vllm-workspace/
181181

182182
# install development dependencies (for testing)
183-
# A newer setuptools is required for installing some test dependencies from source that do not publish python 3.12 wheels
184-
# This installation must complete before the test dependencies are collected and installed.
185-
RUN --mount=type=cache,target=/root/.cache/pip \
186-
python3 -m pip install "setuptools>=74.1.1"
187183
RUN --mount=type=cache,target=/root/.cache/pip \
188184
python3 -m pip install -r requirements-dev.txt
189185

requirements-common.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,4 +29,5 @@ importlib_metadata
2929
mistral_common >= 1.4.0
3030
pyyaml
3131
six>=1.16.0; python_version > '3.11' # transitive dependency of pandas that needs to be the latest version for python 3.12
32+
setuptools>=74.1.1; python_version > '3.11' # Setuptools is used by triton, we need to ensure a modern version is installed for 3.12+ so that it does not try to import distutils, which was removed in 3.12
3233
einops # Required for Qwen2-VL.

0 commit comments

Comments
 (0)