-
-
Notifications
You must be signed in to change notification settings - Fork 8k
[Bugfix]: Fix the incompatibility issue with tool_choice 'required' when Thinking is enabled #19075
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugfix]: Fix the incompatibility issue with tool_choice 'required' when Thinking is enabled #19075
Conversation
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
…hen Thinking is enabled Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
1a305fc
to
063844c
Compare
test
output
|
cdd3e3c
to
e49bc63
Compare
/cc @meffmadd @aarnphm @DarkLight1337 PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. One comment abt the test model
tests/entrypoints/openai/test_completion_with_function_calling.py
Outdated
Show resolved
Hide resolved
ec0560e
to
3c670d5
Compare
…hen Thinking is enabled Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
3c670d5
to
f8cb8df
Compare
FIX #19051
Introduced by PR #16577.