-
-
Notifications
You must be signed in to change notification settings - Fork 7.5k
[V1] Structured Outputs + Thinking compatibility #16577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[V1] Structured Outputs + Thinking compatibility #16577
Conversation
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
cc @gaocegege might be interested |
cbc3320
to
f60e62d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. Please also update the docs https://docs.vllm.ai/en/latest/features/reasoning_outputs.html#structured-output
- VLLM_USE_V1=0 vllm serve deepseek-ai/DeepSeek-R1-Distill-Qwen-1.5B \
--enable-reasoning --reasoning-parser deepseek_r1
+ vllm serve deepseek-ai/DeepSeek-R1-Distill-Qwen-1.5B \
--enable-reasoning --reasoning-parser deepseek_r1
This pull request has merge conflicts that must be resolved before it can be |
14490de
to
2cf21f0
Compare
Signed-off-by: Aaron Pham <contact@aarnphm.xyz>
Head branch was pushed to by a user without write access
…t-thinking-struct-outputs
…t-thinking-struct-outputs
Signed-off-by: Aaron Pham <contact@aarnphm.xyz>
Head branch was pushed to by a user without write access
Signed-off-by: Aaron Pham <contact@aarnphm.xyz>
Signed-off-by: Aaron Pham <contact@aarnphm.xyz>
Signed-off-by: Aaron Pham <contact@aarnphm.xyz>
Signed-off-by: Aaron Pham <contact@aarnphm.xyz>
Signed-off-by: Aaron Pham <contact@aarnphm.xyz>
Signed-off-by: Aaron Pham <contact@aarnphm.xyz>
Signed-off-by: Aaron Pham <contact@aarnphm.xyz>
Signed-off-by: Aaron Pham <contact@aarnphm.xyz>
Signed-off-by: Aaron Pham <contact@aarnphm.xyz>
seems like the failure on entrypoint is not related 😿 |
Signed-off-by: Nathan Hoos <thwackyy.y@gmail.com>
…t-thinking-struct-outputs
Signed-off-by: Aaron Pham <contact@aarnphm.xyz>
Head branch was pushed to by a user without write access
Signed-off-by: Aaron Pham <contact@aarnphm.xyz> Co-authored-by: Russell Bryant <rbryant@redhat.com>
Signed-off-by: Aaron Pham <contact@aarnphm.xyz> Co-authored-by: Russell Bryant <rbryant@redhat.com> Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com>
Signed-off-by: Nathan Hoos <thwackyy.y@gmail.com>
This PR brings thinking support to structured outputs in V1. Currently, if you want to use thinking parser in conjunction with structured outputs, you have to use the V0 engine.
This is also compatible with speculative decoding
This PR also refactor the tokenizer onto the structured_output_manager in order to construct the reasoner.
I have also added tests to cover this case.
Tests with the following:
Closes #14727