Skip to content

[Bugfix][CPU] Fix broken AVX2 CPU TP support #17252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 9, 2025

Conversation

Isotr0py
Copy link
Collaborator

@Isotr0py Isotr0py commented Apr 27, 2025

FIX #16800 (link existing issues this PR will resolve)

[rank0]: AttributeError: '_OpNamespace' '_C' object has no attribute 'init_shm_manager'
  • Add native torch.distributed fallback for AVX2 CPU, since _CPUSHMDistributed are only available for AVX512 CPU.

Signed-off-by: Isotr0py <2037008807@qq.com>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@Isotr0py Isotr0py requested a review from youkaichao April 27, 2025 08:45
@Isotr0py Isotr0py enabled auto-merge (squash) May 9, 2025 07:19
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label May 9, 2025
@Isotr0py Isotr0py merged commit 6e4a93e into vllm-project:main May 9, 2025
74 of 75 checks passed
@Isotr0py Isotr0py deleted the fix-cpu-tp branch May 9, 2025 14:24
princepride pushed a commit to princepride/vllm that referenced this pull request May 10, 2025
Signed-off-by: Isotr0py <2037008807@qq.com>
Signed-off-by: 汪志鹏 <wangzhipeng628@gmail.com>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
Signed-off-by: Isotr0py <2037008807@qq.com>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
mawong-amd pushed a commit to ROCm/vllm that referenced this pull request May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Non-avx512 CPUs cannot use tensor parallelism
2 participants