Skip to content

[V1][Spec Decode] Eagle unit tests #17350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 12, 2025

Conversation

wwl2755
Copy link
Contributor

@wwl2755 wwl2755 commented Apr 29, 2025

This PR adds comprehensive unit tests for the EagleProposer class, including model loading, token proposal generation, and input preparation for both Eagle and Eagle3 variants.

With these tests in place, developers can more easily verify and tune the functionality of the speculative decoding implementation.

Any comment or guidance are appreciated! @LiuXiaoxuanPKU @WoosukKwon

wwl2755 added 5 commits April 27, 2025 06:45
Signed-off-by: wwl2755 <wangwenlong2755@gmail.com>
Signed-off-by: wwl2755 <wangwenlong2755@gmail.com>
Signed-off-by: wwl2755 <wangwenlong2755@gmail.com>
Signed-off-by: wwl2755 <wangwenlong2755@gmail.com>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the v1 label Apr 29, 2025
Copy link

mergify bot commented Apr 30, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @wwl2755.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Apr 30, 2025
@houseroad houseroad requested review from zixi-qi and morgendave May 5, 2025 05:25
Copy link
Collaborator

@zixi-qi zixi-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

wwl2755 added 2 commits May 7, 2025 20:41
Signed-off-by: wwl2755 <wangwenlong2755@gmail.com>
Signed-off-by: wwl2755 <wangwenlong2755@gmail.com>
@mergify mergify bot removed the needs-rebase label May 7, 2025
@wwl2755
Copy link
Contributor Author

wwl2755 commented May 7, 2025

Hi @zixi-qi , I have just rebased on main and fix the tests for new commits accordingly. PTAL. Thank you!

cc: @WoosukKwon @LiuXiaoxuanPKU

@zixi-qi
Copy link
Collaborator

zixi-qi commented May 8, 2025

Hi @zixi-qi , I have just rebased on main and fix the tests for new commits accordingly. PTAL. Thank you!

cc: @WoosukKwon @LiuXiaoxuanPKU

Thanks for the update! Changes LGTM

Copy link
Collaborator

@WoosukKwon WoosukKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Sorry for the late review 🙏

@WoosukKwon WoosukKwon added the ready ONLY add when PR is ready to merge/full CI is needed label May 12, 2025
@WoosukKwon WoosukKwon enabled auto-merge (squash) May 12, 2025 21:21
@WoosukKwon WoosukKwon merged commit dc99053 into vllm-project:main May 12, 2025
53 checks passed
mawong-amd pushed a commit to ROCm/vllm that referenced this pull request May 14, 2025
Signed-off-by: wwl2755 <wangwenlong2755@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed speculative-decoding v1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants