-
-
Notifications
You must be signed in to change notification settings - Fork 7.5k
[V1][Spec Decode] Eagle unit tests #17350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: wwl2755 <wangwenlong2755@gmail.com>
Signed-off-by: wwl2755 <wangwenlong2755@gmail.com>
Signed-off-by: wwl2755 <wangwenlong2755@gmail.com>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
This pull request has merge conflicts that must be resolved before it can be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: wwl2755 <wangwenlong2755@gmail.com>
Signed-off-by: wwl2755 <wangwenlong2755@gmail.com>
Hi @zixi-qi , I have just rebased on main and fix the tests for new commits accordingly. PTAL. Thank you! |
Thanks for the update! Changes LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Sorry for the late review 🙏
Signed-off-by: wwl2755 <wangwenlong2755@gmail.com>
This PR adds comprehensive unit tests for the
EagleProposer
class, including model loading, token proposal generation, and input preparation for both Eagle and Eagle3 variants.With these tests in place, developers can more easily verify and tune the functionality of the speculative decoding implementation.
Any comment or guidance are appreciated! @LiuXiaoxuanPKU @WoosukKwon