Skip to content

[easy] Print number of needed GPUs in skip message #17594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 2, 2025
Merged

[easy] Print number of needed GPUs in skip message #17594

merged 1 commit into from
May 2, 2025

Conversation

zou3519
Copy link
Collaborator

@zou3519 zou3519 commented May 2, 2025 •
edited by github-actions bot
Loading

tests/compile/test_basic_correctness requires a specific number of GPUs to run. I changed the skip message to print it.

Separately I'm looking into if there's another way to run this test, because I have an 8 GPU machine and I would like to run these without setting CUDA_VISIBLE_DEVICES all the time.

@zou3519
[easy] Print number of needed GPUs in skip message
f3c41d2 
tests/compile/test_basic_correctness requires a specific number of GPUs
to run. I changed the skip message to print it.

Separately I'm looking into if there's another way to run this test,
because I have an 8 GPU machine and I would like to run these without
setting CUDA_VISIBLE_DEVICES all the time.

Signed-off-by: rzou <zou3519@gmail.com>
@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@zou3519 zou3519 marked this pull request as ready for review May 2, 2025 15:58
houseroad
houseroad approved these changes May 2, 2025
View reviewed changes
Copy link
Collaborator

@houseroad houseroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@houseroad houseroad added the ready ONLY add when PR is ready to merge/full CI is needed label May 2, 2025
@houseroad houseroad merged commit b90b085 into vllm-project:main May 2, 2025
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houseroad houseroad houseroad approved these changes

@tlrmchlsmth tlrmchlsmth Awaiting requested review from tlrmchlsmth

@mgoin mgoin Awaiting requested review from mgoin

@youkaichao youkaichao Awaiting requested review from youkaichao

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zou3519 @houseroad