Skip to content

Handle error when str passed to /v1/audio/transcriptions #17909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

hmellor
Copy link
Member

@hmellor hmellor commented May 9, 2025

Solves part of #17038

Server side:

INFO:     127.0.0.1:42508 - "POST /v1/audio/transcriptions HTTP/1.1" 422 Unprocessable Entity

Client side:

$ curl -X POST -H 'Content-Type: application/x-www-form-urlencoded' -d file=b%27%27 --insecure http://127.0.0.1:8000/v1/audio/transcriptions
{"detail":"Unsupported type for 'file'. Audio file should be a 'fastapi.UploadFile' object, not 'str'."}

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Copy link

github-actions bot commented May 9, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@DarkLight1337
Copy link
Member

Is this consistent with what you get if you send a string to the actual OpenAI API?

@hmellor
Copy link
Member Author

hmellor commented May 9, 2025

https://platform.openai.com/docs/guides/speech-to-text looks like it actually wants an open file handle, I could update the message to say that?

@DarkLight1337
Copy link
Member

Yeah let's keep the message similar to the actual OpenAI API

Copy link
Member

@russellb russellb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@russellb
Copy link
Member

russellb commented May 9, 2025

not sure why pre-commit fails on a file you didn't change, but your change lgtm

A test would be ideal, but I won't block on it

@russellb russellb enabled auto-merge (squash) May 9, 2025 15:54
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label May 9, 2025
@hmellor
Copy link
Member Author

hmellor commented May 9, 2025

#17864 (comment)

hmellor added 2 commits May 9, 2025 18:09
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
@russellb russellb merged commit 7d4aeda into vllm-project:main May 9, 2025
51 checks passed
@hmellor hmellor deleted the fix-transcription-error-response branch May 9, 2025 19:30
princepride pushed a commit to princepride/vllm that referenced this pull request May 10, 2025
…oject#17909)

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: 汪志鹏 <wangzhipeng628@gmail.com>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
…oject#17909)

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
mawong-amd pushed a commit to ROCm/vllm that referenced this pull request May 14, 2025
…oject#17909)

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants