-
-
Notifications
You must be signed in to change notification settings - Fork 7.5k
Handle error when str
passed to /v1/audio/transcriptions
#17909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle error when str
passed to /v1/audio/transcriptions
#17909
Conversation
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Is this consistent with what you get if you send a string to the actual OpenAI API? |
https://platform.openai.com/docs/guides/speech-to-text looks like it actually wants an open file handle, I could update the message to say that? |
Yeah let's keep the message similar to the actual OpenAI API |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
not sure why pre-commit fails on a file you didn't change, but your change lgtm A test would be ideal, but I won't block on it |
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
…oject#17909) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: 汪志鹏 <wangzhipeng628@gmail.com>
…oject#17909) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
…oject#17909) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Solves part of #17038
Server side:
INFO: 127.0.0.1:42508 - "POST /v1/audio/transcriptions HTTP/1.1" 422 Unprocessable Entity
Client side: